bad instructions in mysql upgrade guide

Open jmhodges opened this issue 8 years ago • 1 comments

This instruction in the v1-to-v3 upgrade guide for mysql:

Wrap your existing migrations in transactions (BEGIN/COMMIT) if you use multiple statements within one migration.

doesn't work in mysql because ALTER statements and similar are always committed immediately without respect to transactions. See https://dev.mysql.com/doc/refman/5.7/en/implicit-commit.html

I haven't dug into the new v3 design, but, if this is required, it seems likely to have repercussions elsewhere.

Oct 11 '17 21:10 jmhodges

In that case, ALTER can't be wrapped in a transaction. migrate won't wrap any SQL commands. so that should be fine?

Oct 12 '17 18:10 mattes