Add e2e tests for disable plugin command

[akshaychhajed]

Summary

Add e2e tests for disable plugin command

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/16078

[mattermod]

Hello @akshaychhajed,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[agnivade]

Please feel free to request my review when it's ready.

[akshaychhajed]

@agnivade ok. I will.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[jasonblais]

@akshaychhajed Let us know if you have any questions about the previous feedback, we'd be happy to help :)

[akshaychhajed]

@jasonblais i am away from keyboard and be back over weekend. I will update when i am back.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[jfrerich]

Hi, @akshaychhajed - checking in on this PR also to see if you've made progress or need any additional help :)

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[jfrerich]

Hi @akshaychhajed! Just checking in again to see if you need any help. I'd love to get this merged, or open it back up for another contributor

[akshaychhajed]

@jfrerich I want to get this merged too. Sorry, I was away from keyboard.

[jfrerich]

No worries, @akshaychhajed! I was just checking in to make sure the PR wasn't abandoned :) Let us know if you need any assistance!

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[emilyacook]

Hey @akshaychhajed! Let me know if you have time to take action on this, otherwise I'll need to update the status as per our inactive contribution guidelines

[akshaychhajed]

Thank you for your patience! I updated PR with requested changes.

I could not get the pluginID for test. I have marked the plugin constant below https://github.com/mattermost/mmctl/pull/275/files#diff-cd6aeaed48e9efc5c7a1b72d620073ca953d5e724099f7bc74206a33a2a81afcR18

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[mgdelacroix]

@akshaychhajed can you please take a look at the test that is failing in the CI?

--- FAIL: TestMmctlE2ESuite/TestPluginDisableCmd (5.04s)
plugin_e2e_test.go:156: 
      	Error Trace:	plugin_e2e_test.go:156
       	            				plugin_e2e_test.go:27
       	Error:      	Expected nil, but got: invalid url /go/src/github.com/mattermost/mattermost-server/tests/testplugin.tar.gz
       	Test:       	TestMmctlE2ESuite/TestPluginDisableCmd

[akshaychhajed]

@mgdelacroix sure. Let me take a look.

[akshaychhajed]

@mgdelacroix I used the path @isacikgoz suggested here

Unfortunately DownloadFromUrl expects a http path. https://github.com/mattermost/mattermost-server/blob/8d6dd195e1d8cdcd2ed7aaa12da95125cc2033c4/app/download.go#L26

Is there http path for test plugin? I also need test plugin id.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[isacikgoz]

/update-branch

[mattermod]

Error trying to update the PR. Please do it manually.

[isacikgoz]

/update-branch

[hanzei]

Thank you for your contribution. :+1: mmctl has been moved into https://github.com/mattermost/mattermost/tree/master/server/cmd/mmctl. Please resubmit your PR to https://github.com/mattermost/mattermost.