mattermost icon indicating copy to clipboard operation
mattermost copied to clipboard

[MM-56921] Rendered Latex in Codeblock when rendering disabled

Open harmeet01singh opened this issue 1 year ago • 19 comments

Summary

When Latex Rendering is disabled in Settings, The Code will be displayed inside a Code block.

Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/26267 Jira https://mattermost.atlassian.net/browse/MM-56921

Screenshots

before after
image image

Release Note

Render Latex in a code block as code when Latex rendering is disabled

harmeet01singh avatar May 18 '24 16:05 harmeet01singh

@harmeet01singh: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar May 18 '24 16:05 mm-cloud-bot

Hello @harmeet01singh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermost-build avatar May 18 '24 16:05 mattermost-build

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar May 31 '24 01:05 mattermost-build

/autoassign

harmeet01singh avatar Jun 20 '24 05:06 harmeet01singh

In response to this

I'm requesting the Pull Panda autoassigner to add reviewers to this PR.

mattermost-build avatar Jun 20 '24 05:06 mattermost-build

Not triggering E2E tests: this PR has 1 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

unified-ci-app[bot] avatar Jun 20 '24 06:06 unified-ci-app[bot]

/update-branch

yasserfaraazkhan avatar Jun 25 '24 21:06 yasserfaraazkhan

@harmeet01singh can you please take a look at failing test?

yasserfaraazkhan avatar Jun 25 '24 21:06 yasserfaraazkhan

Yes, Will look into them in some time

harmeet01singh avatar Jun 26 '24 11:06 harmeet01singh

@hmhealey @yasserfaraazkhan Please check once.

harmeet01singh avatar Jun 29 '24 15:06 harmeet01singh

Fixed Lint errors. Is there any way to run only the lint check on PR? So that I don't have to wait for all the other checks... @yasserfaraazkhan

harmeet01singh avatar Jun 30 '24 15:06 harmeet01singh

Fixed Lint errors. Is there any way to run only the lint check on PR? So that I don't have to wait for all the other checks... @harmeet01singh

On the PR only lint job is not possible. We have to run it locally (cmd ) to fix any error and push. Lint check has passed now. Just a snapshot test needs a fix

yasserfaraazkhan avatar Jun 30 '24 15:06 yasserfaraazkhan

@hmhealey , Could you approve if all the requested changes have been fulfilled. Thanks in advance.

harmeet01singh avatar Jul 01 '24 09:07 harmeet01singh

Test server destroyed

mm-cloud-bot avatar Jul 09 '24 20:07 mm-cloud-bot