mattermost icon indicating copy to clipboard operation
mattermost copied to clipboard

Migrate "components/integrations/abstract_incoming_webhook.jsx" to Typescript

Open mattermod opened this issue 2 years ago • 1 comments

We are plan to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify the above mentioned file and associate test files (if the file exists).

Below is a checklist of items you should be doing to migrate:

  • Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx).
  • Add relevant types in the component(s) code.
  • Update any components using those to the correct imports.
  • Fix any errors generated by the TypeScript compiler. You can run rpm run check-types to display any errors.

We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-47095

mattermod avatar Sep 21 '22 14:09 mattermod

I would like to work on this.

AbhinavVihan avatar Sep 22 '22 11:09 AbhinavVihan

I would like to work on this

BediNimret avatar Oct 20 '22 08:10 BediNimret

@M-ZubairAhmed can you please assign this issue to me?

abhinav700 avatar Jul 03 '23 06:07 abhinav700

Thanks. Will work on it.

abhinav700 avatar Jul 03 '23 10:07 abhinav700

Thank you @abhinav700 please let me know if you have any questions regarding the task

M-ZubairAhmed avatar Jul 03 '23 10:07 M-ZubairAhmed

Sorry for this. That last PR was closed because it was resubmitted against this repository after we moved the web app code, so this has actually been done already. We do still appreciate the work you've done on this though

hmhealey avatar Jul 05 '23 18:07 hmhealey