mattermost icon indicating copy to clipboard operation
mattermost copied to clipboard

Update Header with application/json

Open safakkizkin opened this issue 2 years ago • 5 comments

Summary

Assigned content type application/json for NotFound (404), to stay true to the document.

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/20878 JIRA: https://mattermost.atlassian.net/browse/MM-46605

Release Note

NONE

safakkizkin avatar Sep 19 '22 19:09 safakkizkin

@safakkizkin: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Sep 19 '22 19:09 mm-cloud-bot

Hello @safakkizkin,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Sep 19 '22 19:09 mattermod

@noxer - mind taking a look ? :)

agnivade avatar Sep 20 '22 11:09 agnivade

Hi @safakkizkin and thank you for your contribution. I'd like to request a small change and then this should be good to go.

noxer avatar Sep 21 '22 09:09 noxer

Hi @noxer, yes you are totaly right!

safakkizkin avatar Sep 21 '22 16:09 safakkizkin

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/243862

mattermod avatar Sep 24 '22 09:09 mattermod

ping @isacikgoz

edit: Sorry, Github showed the first comment as not sent.

noxer avatar Sep 27 '22 23:09 noxer

rebased to be sure everything is great

safakkizkin avatar Sep 28 '22 19:09 safakkizkin

/e2e-test

noxer avatar Sep 29 '22 14:09 noxer

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/245490

mattermod avatar Sep 29 '22 14:09 mattermod

Merged, thank you!

noxer avatar Sep 29 '22 18:09 noxer