Add UserHasBeenDeactivated plugin hook

[MatthewDorner]

Summary

Add a new Plugin hook, UserHasBeenDeactivated as specified by @mickmister here: https://github.com/mattermost/mattermost-plugin-gitlab/issues/287. Goes with the plugin PR: https://github.com/mattermost/mattermost-plugin-gitlab/pull/315.

Ticket Link

https://github.com/mattermost/mattermost-plugin-gitlab/issues/287

Release Note

Added the Plugin hook "UserHasBeenDeactivated"

[mm-cloud-bot]

@MatthewDorner: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[mattermod]

Hello @MatthewDorner,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[MatthewDorner]

Does the new hook need to be added to some documentation repos?

[MatthewDorner]

Hmm, didn't realize I could only request review from one person lol.

[hanzei]

/update-branch

[mattermod]

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/243385

[hanzei]

@DHaussermann This PR should be testing alongside with https://github.com/mattermost/mattermost-plugin-gitlab/pull/315

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

[isacikgoz]

Hi @MatthewDorner, big thanks for your contribution! There hasn't been recent activity on this PR so I've marked it as inactive. Following our inactive contribution process, the PR is now closed due to 30 days or more of inactivity.

However, if you're still interested working on the changes, let us know! Note that we merged multiple repositories into one monorepo, which may require you to resubmit the changes.

If you have any questions, don't hesitate to let us know, we're happy to help.

[hanzei]

@isacikgoz Can you please elaborate on why the PR was closed? It was blocked by the missing review of @DHaussermann, not because an action from the community member was missing.

[DHaussermann]

@hanzei and @isacikgoz we could re-open this.

That said I don't know of an option for functional testing. We might need to implement the use of the hook in the demo plugin.

[hanzei]

@DHaussermann @MatthewDorner provided an implemenation of the hook via https://github.com/mattermost/mattermost-plugin-gitlab/pull/315. Can you use that for testing?

[isacikgoz]

@hanzei Sorry for the late reply, I was OOO for a while. I closed many PRs to cleanup some stale work. For this one I may missed the context and any time we can re-open this if necessary. Feel free to do so.

[hanzei]

/update-branch

[hanzei]

I've submitted a PR to the plugin that makes use of the new hook.

@DHaussermann I've tested the above-linked PR and can confirm that this PR works as expected. Are we good in terms of QA testing then?

[hanzei]

@MatthewDorner Would you mind If I also add a UserHasBeenActivated hook?

[mickmister]

@hanzei LGTM. Also in agreement this is good to merge @DHaussermann

[mattermost-build]

You don't have permissions to trigger this command. It's only available for organization members.

[hanzei]

QA deferred by the above comment. cc @DHaussermann

[DHaussermann]

Understood. Thanks @hanzei!