mattermost icon indicating copy to clipboard operation
mattermost copied to clipboard

CRT: Channel preference to auto-follow all threads in the channel

Open mattermod opened this issue 2 years ago • 5 comments

Currently the only way to auto-follow threads is to participate in them, start them or be mentioned.

This ticket is to add a channel notification preference to auto-follow all threads in a specific channel. With this setting enabled, every thread in the specific channel will be auto-followed and appear in users Threads view. The default is off.

Figma design (with notes)

https://www.figma.com/file/LR6SGToLAUbrnGxM0i0rp8/?node-id=0%3A1


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-37933

mattermod avatar Jun 21 '22 15:06 mattermod

@esethna I would like to work on this but do I need to wait for the implementation of New Notifications Preferences Modal before starting to work on this. Because preference to auto-follow has different UI in new notifications preferences modal

sinansonmez avatar Jun 30 '22 08:06 sinansonmez

@sinansonmez there's actually a version of this in the figma file for the old modal design (so it doesn't have to be blocked): image

esethna avatar Jul 05 '22 19:07 esethna

@doranych @Shabablinchikow I noticed you thumbs downed this feature. Can I ask for some feedback? :)

Note that this setting is per user and not enabled by default, it's only for those users that choose they want to closely follow every conversation in a particular channel and not miss anything.

esethna avatar Jul 05 '22 19:07 esethna

@esethna thanks for the clarification. Currently I have bunch of tickets assigned to me. I will try to tackle them first. Then I will try to work on this if no one takes this issue by that time

sinansonmez avatar Jul 05 '22 21:07 sinansonmez

I would like to take a stab at this

chrishanthmathew91 avatar Aug 08 '22 11:08 chrishanthmathew91

@esethna I have a couple of doubts.

  1. I have a bunch of text that needs translation. How do I go about it?
  2. Is there any way to simulate multiple users in my local instance? I would like to test out threads created by different users to see if my implementation is correct

chrishanthmathew91 avatar Aug 15 '22 15:08 chrishanthmathew91

@chrishanthmathew91 excited to see this!

  1. As long as you've added the strings to the en.json then they will get translated by our community as part of the release process (so no need to worry about that)
  2. I believe you can do a /test users 10 to add users. Although the easiest way is probably just to create a few users in your test instance and have them logged in via different browsers or incognito windows so you can observe and test on multiple accounts at once

esethna avatar Aug 16 '22 19:08 esethna

@esethna I have another doubt with regards to the behaviour:

Currently, threads can be auto-followed by being mentioned, starting or participating in the thread. In addition, we can also manually follow threads. Consider the following scenario. When we toggle on the auto-follow switch, it will cause all unfollowed threads in the channel to be followed. Now when we toggle off auto-follow, what is the expected behaviour? Do we expect all followed threads to be unfollowed or do we expect the mentioned, participated or manually followed threads to maintain their "followed" state?

Also, does toggling on follow even older, unfollowed threads in the channel or only the upcoming threads?

chrishanthmathew91 avatar Aug 20 '22 18:08 chrishanthmathew91

@chrishanthmathew91 excellent questions we hadn't considered. Here's my thoughts, and I'll also tag @matthewbirtch for his comments.

  1. Toggling on should only auto-follow new threads that get created in the channel. We want to avoid doing a heavy migration or computation when the feature is turned on. @matthewbirtch perhaps we want to update the help text to make that more clear?

  2. Toggling off the feature should not unfollow any threads - otherwise users might have trouble locating old threads they used to find in the Threads view.

Thoughts or concerns with this approach?

esethna avatar Aug 22 '22 20:08 esethna

@chrishanthmathew91 excellent questions we hadn't considered. Here's my thoughts, and I'll also tag @matthewbirtch for his comments.

  1. Toggling on should only auto-follow new threads that get created in the channel. We want to avoid doing a heavy migration or computation when the feature is turned on. @matthewbirtch perhaps we want to update the help text to make that more clear?
  2. Toggling off the feature should not unfollow any threads - otherwise users might have trouble locating old threads they used to find in the Threads view.

Thoughts or concerns with this approach?

@esethna I agree with your comments here - and I believe I had the first item noted in the design file:

image

matthewbirtch avatar Aug 22 '22 21:08 matthewbirtch

Sorry, I know this is not releated directly, but could we add the following feature to this issue?

Allow to disable thread autofollow when whole channel was mentioned:

Add parameter that allows Mattermost admin, to disable thread autofollow while having collapsed reply thread turned on while mass mentions are used (@channel, @all, @here). I want my users to get notification, but not to follow this thread automatically, afaik, this is not possible at this moment.

danilvalov avatar Sep 15 '23 10:09 danilvalov

Sorry, I know this is not releated directly, but could we add the following feature to this issue?

Allow to disable thread autofollow when whole channel was mentioned:

Add parameter that allows Mattermost admin, to disable thread autofollow while having collapsed reply thread turned on while mass mentions are used (@channel, @all, @here). I want my users to get notification, but not to follow this thread automatically, afaik, this is not possible at this moment.

@danilvalov we have a separate ticket for this: https://mattermost.atlassian.net/browse/MM-37813

matthewbirtch avatar Sep 15 '23 15:09 matthewbirtch

I want to take this

tanmaythole avatar Sep 21 '23 05:09 tanmaythole

Can somebody explain what is the difference between this issue, and that feature of the v8.0 release?

Added a new option to auto-follow all threads in the channel Notification Preference settings.

I just checked, and the feature is definitely there (tested on server version 9.1.1 with desktop client 5.4.0).

lenaschimmel avatar Nov 05 '23 22:11 lenaschimmel

Can somebody explain what is the difference between this issue, and that feature of the v8.0 release?

Added a new option to auto-follow all threads in the channel Notification Preference settings.

I just checked, and the feature is definitely there (tested on server version 9.1.1 with desktop client 5.4.0).

Thank you. Also checked and it looks like what I was looking for )

dmitry-j-mikhin avatar Nov 12 '23 07:11 dmitry-j-mikhin

@amyblais @esethna I think we can close this issue right? It's already in the product as of 8.0.

matthewbirtch avatar Nov 13 '23 14:11 matthewbirtch

That's great, thanks for the feature!

Note the doc says Channel Notification Preference settings can also be accessed from "Select the channel name, then select Notification Preferences", but in the web app it does not seem to be possible (and it would be a great time saver when you want to apply that setting to most/all of your chans)

ydirson avatar Dec 04 '23 09:12 ydirson

I was very excited to learn this feature was implementd. It's much appreciated. I'd still really appreciate a GLOBAL version of this flag so I don't need to do this for every channel.

dovholuknf avatar Apr 25 '24 19:04 dovholuknf