Create config setting to always have the team sidebar visible

[mattermod]

Some plugins render their components in the team sidebar, but the sidebar is only visible when the user is a member of more than one team. It would be useful to be able to configure the system to always show the team sidebar, so that users with only one team membership can use the plugin properly.

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-37445

[vriyashartama]

Hello, I'm interested to this issue. May i take this up?

[haardikdharma10]

Hi @liehart, sure, please go ahead. As this is Up For Grabs, you can start working on it and someone will assign it to you shortly.

[vriyashartama]

Does this issue have to be implemented at mattermost-webapp too? For server side I have open a PR https://github.com/mattermost/mattermost-server/pull/18013. Please let me know if i did correctly.

[alexpitsikoulis]

Hey is this still an open issue/unassigned ?

[amyblais]

Hey is this still an open issue/unassigned ?

@alexpitsikoulis Yes, would you like me to assign this to you?

[alexpitsikoulis]

@amyblais yes please

[mickmister]

Hi @alexpitsikoulis, just checking in. Do you have any questions about this issue?

[safakkizkin]

Hi @mickmister, I think we don't need to show always Team Sidebar visible, unless we have plugins that needs to showTeamSidebar or the user is member of multiple teams. I believe that will solve our issues here, without any config file update.

So, if this solution makes sense for you. I'll create a PR for it only on web app side.

It helps so much if you gave me an example for plugin (I couldn't find) that uses team sidebar 😅

[mickmister]

@safakkizkin Yes that solution makes perfect sense to me :+1:

The GitHub plugin uses this feature. Note that it conditionally renders content in two places depending on if the team sidebar is showing. Just mentioning this for context. https://github.com/mattermost/mattermost-plugin-github

Thanks for looking into this!!

[safakkizkin]

@mickmister I took a lot to this issue but I come no solution. At some point I could not figure out more.

Let me explain what I looked up and what I really end up with.

1. We use Pluggable to render all the plugins where it should be.
2. There are multiple places for plugins to stay still, eg. team-sidebar-bottom-plugin and sidebar--left__icons...
3. And those are ends up here

This is what I currently understood.

Even the team sidebar visible for a user that member only a team, the plugin renders on sidebar not the team_sidebar. I could not figure where do i miss the shot. I believe its right in front my eyes but, i need some help to understand it better.

Thanks a lot.

[mickmister]

Even the team sidebar visible for a user that member only a team, the plugin renders on sidebar not the team_sidebar

@safakkizkin The plugin is choosing to render in the sidebar (and not team_sidebar) because it is explicitly checking if the user is a member of multiple teams before making this choice of where to render. It is not actually checking "is the team sidebar visible".

I think this behavior is acceptable, as the requirement of showing the sidebar has been accomplished. It's the individual plugin logic that's making it so that is "incorrect".

[kyeongsoosoo]

@mickmister Can I take this issue?