mattermost
mattermost copied to clipboard
Migrate 'components/toast_wrapper' and associated tests to TypeScript
We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted
issue is to modify components/toast_wrapper
and associated test files.
Below is a checklist of items you should be doing to migrate:
- < ] Rename the files to their associated TypeScript extensions (ie.
js
tots
,jsx
totsx
) - [ ] Update any components using those to the correct imports
- [ > Fix any errors generated by the TypeScript compiler. You can run
make check-types
to display any errors.
We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json
, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.
Some examples of already migrated files can be found here:
- https://github.com/mattermost/mattermost-webapp/pull/3790
- https://github.com/mattermost/mattermost-webapp/pull/3472
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
JIRA: https://mattermost.atlassian.net/browse/MM-34347
I will work on this one.
@amyblais Ma'am, Can I take up this issue, would be great if you could guide me as I am new to mattermost open source!.
Feel free to join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel. Please also see our Developer's Guide.
it would be appreciated if you mentioned me before unassigning the issue. @amyblais
thanks.
@majidsajadi I'm sorry about that! :( Are you still working on this? If yes, I can re-assign this to you and communicate to Pulkit3234
.
@amyblais it's ok. I was about to clean up the code and send the PR. but let @Pulkit3234 work on it.
@amyblais could you please assign it to me?
Hello @amyblais may I be assigned to this issue?
Hi @diegovega49 I have started to do some changes on this ticket but feel free to start working on the issue. I am sure @amyblais will assign it to you soon.
You can also join https://community.mattermost.com in case of any questions or leave a comment here
It is always good to see new members in the community :)
@M-ZubairAhmed please assign this to me and I will close it