mattermost icon indicating copy to clipboard operation
mattermost copied to clipboard

Migrate 'components/toast_wrapper' and associated tests to TypeScript

Open mattermod opened this issue 3 years ago • 9 comments

We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify components/toast_wrapper and associated test files.

Below is a checklist of items you should be doing to migrate:

  • < ] Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx)
  • [ ] Update any components using those to the correct imports
  • [ > Fix any errors generated by the TypeScript compiler. You can run make check-types to display any errors.

We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:

  1. https://github.com/mattermost/mattermost-webapp/pull/4230

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-34347

mattermod avatar Mar 26 '21 18:03 mattermod

I will work on this one.

majidsajadi avatar May 14 '21 16:05 majidsajadi

@amyblais Ma'am, Can I take up this issue, would be great if you could guide me as I am new to mattermost open source!.

Pulkit3234 avatar Jun 20 '21 11:06 Pulkit3234

Feel free to join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel. Please also see our Developer's Guide.

amyblais avatar Jun 20 '21 23:06 amyblais

it would be appreciated if you mentioned me before unassigning the issue. @amyblais

thanks.

majidsajadi avatar Jun 29 '21 15:06 majidsajadi

@majidsajadi I'm sorry about that! :( Are you still working on this? If yes, I can re-assign this to you and communicate to Pulkit3234.

amyblais avatar Jun 29 '21 16:06 amyblais

@amyblais it's ok. I was about to clean up the code and send the PR. but let @Pulkit3234 work on it.

majidsajadi avatar Jun 29 '21 16:06 majidsajadi

@amyblais could you please assign it to me?

sinansonmez avatar Jul 02 '22 09:07 sinansonmez

Hello @amyblais may I be assigned to this issue?

diegovega49 avatar Jul 06 '22 18:07 diegovega49

Hi @diegovega49 I have started to do some changes on this ticket but feel free to start working on the issue. I am sure @amyblais will assign it to you soon.

You can also join https://community.mattermost.com in case of any questions or leave a comment here

It is always good to see new members in the community :)

sinansonmez avatar Jul 06 '22 19:07 sinansonmez

@M-ZubairAhmed please assign this to me and I will close it

sinansonmez avatar Oct 06 '22 16:10 sinansonmez