mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

[MM-47222] add info for enduser with no account and when on closed server

Open mhd-sln opened this issue 1 year ago • 5 comments

Summary

add info for enduser on /login page with no user account and when on closed server.

Ticket Link

https://mattermost.atlassian.net/browse/MM-47222

Screenshots

before after
Screenshot 2022-10-23 at 19 34 20 Screenshot 2022-10-28 at 23 38 49

Release Note

NONE

mhd-sln avatar Oct 28 '22 20:10 mhd-sln

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 28 '22 20:10 mattermod

Thanks @pvev and @JulienTant. I have added the test case and implemented the suggestions. Can you please review it once more ? I would like to highlight that I have added a new test file for login_close_server_spec.js. I tried adding the test case in the already present file login_spec.js but applying different server config for different test cases in the same file did not seem to work. Please suggest if you think this could be done in a better way ?

mhd-sln avatar Oct 31 '22 15:10 mhd-sln

Please suggest if you think this could be done in a better way

You would need to change the values inside of your test case but make sure the before or beforeEach reset everything back to what is expected by the other test cases.

JulienTant avatar Oct 31 '22 16:10 JulienTant

Please suggest if you think this could be done in a better way

You would need to change the values inside of your test case but make sure the before or beforeEach reset everything back to what is expected by the other test cases.

I tried but it just won't work so I thought of having a separate file for it

mhd-sln avatar Oct 31 '22 16:10 mhd-sln

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/257516

mattermod avatar Nov 02 '22 17:11 mattermod

Test server destroyed

mm-cloud-bot avatar Nov 04 '22 16:11 mm-cloud-bot

Test server destroyed

mm-cloud-bot avatar Nov 04 '22 16:11 mm-cloud-bot