[MM-47362] Remove redux from stores/browser_store

[batebobo]

Summary

Removed redux from browser_store.ts. There were two (IMO) conflicting parts of this class

• Redux convenience functions (action creators + selectors)
• Class properties + functions that deal with the underlying browser storage.

I think that these should be placed in separate places as this violates the single responsibility principle and makes the class harder to comprehend & extend.

The redux convenience funcitons in this class weren't used in many places, so I removed them entirely.

Ticket Link

Release Note

NONE

[mm-cloud-bot]

@batebobo: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[mattermod]

Hello @batebobo,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[mattermod]

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

[batebobo]

/release-note-none

[M-ZubairAhmed]

/release-note-none

[hmhealey]

/e2e-tests

[mattermod]

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/257573

[nevyangelova]

test report: https://mattermost-cypress-report.s3.amazonaws.com/257573-fdd9995-onprem-ent-webapp-pr-11470-mm-ee-test:fdd9995/mochawesome.html

[nevyangelova]

@batebobo could you verify that the failing tests are not related to this change?

You can run them locally by navigating to /e2e/cypress then install packages and run npm run cypress:open

[batebobo]

Sure, @nevyangelova! Is a local pass sufficient to verify this?

[nevyangelova]

@batebobo should be visible on the screenshots yes :)

[batebobo]

Hi! After running the tests locally, some of them seem to be failing. Here's a list:

new_channel_with_board_spec - timeout
with_email_login_spec - 403
with_ldap_login_spec - 403
member_invitation_ui_spec - 403
starter_edition_spec - timeout
poll_spec - timeout
forward_message_from_public_channel_spec - 403
plugin_install_spec - don’t have the demo plugin 
edit_spec - timeout

The 403 errors should be due to configuration and I will install the demo plugin for the plugin_install_spec, but for all other tests the error is the same as in the report @nevyangelova. I'll also run these specs from master just to make sure :)