mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-20820: add a help button to right controls on global header

Open aloks98 opened this issue 1 year ago • 4 comments

Summary

Add a help button for playbooks as feedback button was removed.

I am in doubt if the Keyboard shortcuts button is needed for this scenario?

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/20820

Screenshots

Screenshot 2022-10-25 at 9 58 24 PM Screenshot 2022-10-25 at 9 58 17 PM

Release Note

NA

aloks98 avatar Oct 25 '22 16:10 aloks98

@aloks98: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Oct 25 '22 16:10 mm-cloud-bot

Hello @aloks98,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 25 '22 16:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 25 '22 16:10 mattermod

@calebroseland will know more about this than me. However, I would have expected this to happen in the playbooks plugin.

The related code seems to be at global header right component.

trilopin avatar Oct 26 '22 09:10 trilopin

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 06 '22 01:11 mattermod

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.

If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.

lieut-data avatar Mar 02 '23 21:03 lieut-data