mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-47361 : Remove global state & dispatch from logged_in.tsx

Open batebobo opened this issue 1 year ago • 4 comments

Summary

Included viewChannel in mapDispatchToProps so that we don't have to call it with state and dispatch inside the component

Ticket Link

fixes https://github.com/mattermost/mattermost-server/issues/21248

Related Pull Requests

~- Has server changes (please link here)~ ~- Has mobile changes (please link here)~

NONE

batebobo avatar Oct 25 '22 15:10 batebobo

@batebobo: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Oct 25 '22 15:10 mm-cloud-bot

Hello @batebobo,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 25 '22 15:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 25 '22 15:10 mattermod

cc/ @mkraft

nevyangelova avatar Oct 26 '22 14:10 nevyangelova

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 06 '22 01:11 mattermod

/e2e-test

nevyangelova avatar Nov 07 '22 13:11 nevyangelova

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/259256

mattermod avatar Nov 07 '22 13:11 mattermod

A pipeline with the same environment variables is already running. Please cancel it first with /e2e-cancel, or specify different environment variables.

mattermod avatar Nov 07 '22 13:11 mattermod