mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

[MM-47303] Migrate /enterprise/extend_session/not_extended_when_disabled e2e tests to TypeScript

Open chaiwattsw opened this issue 1 year ago • 7 comments

Summary

Converted following support files to TypeScript

  • with_email_login_spec.js
  • with_ldap_login_spec.js
  • with_saml_login_spec.js

and add types declaration

Ticket Link

fixes https://github.com/mattermost/mattermost-server/issues/21306

Related Pull Requests

Screenshots

Release Note

NONE

chaiwattsw avatar Oct 24 '22 20:10 chaiwattsw

Hello @chaiwattsw,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

mattermod avatar Oct 24 '22 20:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 24 '22 20:10 mattermod

/check-cla

saturninoabril avatar Oct 27 '22 13:10 saturninoabril

@chaiwattsw Please sign the CLA as posted here - https://github.com/mattermost/mattermost-webapp/pull/11428#issuecomment-1289562007, then ping me once done. Thanks for your contribution!

saturninoabril avatar Oct 27 '22 13:10 saturninoabril

/check-cla

chaiwattsw avatar Oct 27 '22 14:10 chaiwattsw

@saturninoabril done!

chaiwattsw avatar Oct 27 '22 14:10 chaiwattsw

/e2e-run

chaiwattsw avatar Oct 27 '22 15:10 chaiwattsw

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 15 '22 01:11 mattermod

@chaiwattsw can you please resolve the conflicts 😄

M-ZubairAhmed avatar Nov 15 '22 07:11 M-ZubairAhmed

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 26 '22 01:11 mattermod

/update-branch

furqanmlk avatar Nov 30 '22 19:11 furqanmlk

Error trying to update the PR. Please do it manually.

mattermod avatar Nov 30 '22 19:11 mattermod

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.

If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.

lieut-data avatar Mar 02 '23 21:03 lieut-data