mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-47111 : Migrate "components/emoji_picker/emoji_picker_tabs" to typescript

Open alexpjohnson opened this issue 2 years ago • 9 comments

Summary

Migrates components/emoji_picker/emoji_picker_tabs to Typescript.

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/21059

Related Pull Requests

Screenshots

Release Note


alexpjohnson avatar Oct 19 '22 20:10 alexpjohnson

@alexpjohnson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Oct 19 '22 20:10 mm-cloud-bot

Hello @alexpjohnson,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 19 '22 20:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 19 '22 20:10 mattermod

@alexpjohnson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Oct 20 '22 05:10 mm-cloud-bot

/release-note-none

M-ZubairAhmed avatar Oct 20 '22 05:10 M-ZubairAhmed

Creating a new SpinWick test server using Mattermost Cloud.

mm-cloud-bot avatar Oct 27 '22 15:10 mm-cloud-bot

Mattermost test server created! :tada:

Access here: https://mattermost-webapp-pr-11401.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

mm-cloud-bot avatar Oct 27 '22 15:10 mm-cloud-bot

/e2e-test

M-ZubairAhmed avatar Oct 28 '22 09:10 M-ZubairAhmed

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/255933

mattermod avatar Oct 28 '22 09:10 mattermod

Thanks @alexpjohnson There is an issue with the emoji picker opening at the top of the screen (see test server screenshot) Screen Shot 2022-11-07 at 7 35 09 PM

jgilliam17 avatar Nov 08 '22 00:11 jgilliam17

@alexpjohnson can you please resolve the conflicts

M-ZubairAhmed avatar Nov 15 '22 07:11 M-ZubairAhmed

/e2e-test

M-ZubairAhmed avatar Nov 19 '22 11:11 M-ZubairAhmed

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/264168

mattermod avatar Nov 19 '22 11:11 mattermod

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 30 '22 01:11 mattermod

/update-branch

M-ZubairAhmed avatar Nov 30 '22 06:11 M-ZubairAhmed

Error trying to update the PR. Please do it manually.

mattermod avatar Nov 30 '22 06:11 mattermod

/update-branch

M-ZubairAhmed avatar Dec 01 '22 13:12 M-ZubairAhmed

Error trying to update the PR. Please do it manually.

mattermod avatar Dec 01 '22 13:12 mattermod

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Dec 12 '22 01:12 mattermod

/update-branch

M-ZubairAhmed avatar Dec 12 '22 14:12 M-ZubairAhmed

Error trying to update the PR. Please do it manually.

mattermod avatar Dec 12 '22 14:12 mattermod

/e2e-test

M-ZubairAhmed avatar Dec 12 '22 14:12 M-ZubairAhmed

Successfully triggered E2E testing! GitLab pipeline | Test dashboard

mattermod avatar Dec 12 '22 14:12 mattermod

@jgilliam17 can you please check this one out :)

M-ZubairAhmed avatar Dec 12 '22 14:12 M-ZubairAhmed

@alexpjohnson can you please rebase branch with master so I can re-trigger e2es. Thanks 🙂

jgilliam17 avatar Dec 12 '22 16:12 jgilliam17

@alexpjohnson can you please rebase branch with master so I can re-trigger e2es. Thanks slightly_smiling_face

Done!

alexpjohnson avatar Dec 12 '22 16:12 alexpjohnson

/e2e-test

jgilliam17 avatar Dec 13 '22 13:12 jgilliam17

Successfully triggered E2E testing! GitLab pipeline | Test dashboard

mattermod avatar Dec 13 '22 14:12 mattermod

Test server destroyed

mm-cloud-bot avatar Dec 13 '22 16:12 mm-cloud-bot