mattermost-webapp
mattermost-webapp copied to clipboard
mattermost
MM-47301: Migrate /enterprise/system_console/about e2e tests to TypeScript
Summary
This PR Migrate /enterprise/system_console/about e2e tests to TypeScript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21330 Fixes https://mattermost.atlassian.net/browse/MM-47301
Release Note
NONE
@adithyaakrishna: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
I understand the commands that are listed here
Hello @adithyaakrishna,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.
Hey @tboulis Okay sure, I'll address the changes and send a commit regarding that :)
@tboulis I have a small doubt, this line of code is giving an error when Cypress.Team is used. Could you please help me with this?
@tboulis I have a small doubt, this line of code is giving an error when Cypress.Team is used. Could you please help me with this?
It seems like you are using the wrong type Cypress.Team. What makes more sense to me is to use the type Cypress.UserProfile because this variable refers to a user that is also an admin. Can you try that and let me know if that works?
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.
If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.
