mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

MM-47298 : Migrate /enterprise/bot_accounts e2e tests to TypeScript

Open Yordaniss opened this issue 1 year ago • 11 comments

Summary

Migrated e2e test from JavaScript to Typescript with type declaration.

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/21310

JIRA: https://mattermost.atlassian.net/browse/MM-47298

Screenshots

Bildschirmfoto 2022-10-13 um 20 42 33

Release Note

NONE

Yordaniss avatar Oct 13 '22 18:10 Yordaniss

@Yordaniss: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Oct 13 '22 18:10 mm-cloud-bot

Hello @Yordaniss,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 13 '22 18:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 13 '22 18:10 mattermod

/release-note-none

M-ZubairAhmed avatar Oct 14 '22 11:10 M-ZubairAhmed

Hello @saturninoabril Thank you for feedback. 👍 I have updated the master branch and adjusted my PR.

Yordaniss avatar Oct 14 '22 20:10 Yordaniss

@saturninoabril Sure, no problem. I already pushed the changes.

Yordaniss avatar Oct 15 '22 08:10 Yordaniss

/update-branch

furqanmlk avatar Oct 21 '22 14:10 furqanmlk

Error trying to update the PR. Please do it manually.

mattermod avatar Oct 21 '22 14:10 mattermod

/e2e-test

furqanmlk avatar Oct 21 '22 14:10 furqanmlk

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/253384

mattermod avatar Oct 21 '22 14:10 mattermod

@furqanmlk Glad to help 😊

Yordaniss avatar Oct 21 '22 16:10 Yordaniss

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Nov 01 '22 01:11 mattermod

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.

If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.

lieut-data avatar Mar 02 '23 21:03 lieut-data