mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-47056: Migrate "components/setting_item_max.jsx" to Typescript

Open babinderrathi opened this issue 2 years ago • 12 comments

Summary

Migration of components/setting_item_max.jsx to Typescript

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/21138 Fixes https://mattermost.atlassian.net/browse/MM-47056

Related Pull Requests

None

Screenshots

None

Release Note

babinderrathi avatar Oct 11 '22 16:10 babinderrathi

Hello @babinderrathi,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 11 '22 16:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 11 '22 16:10 mattermod

@babinderrathi Please fix the type check

AshishDhama avatar Oct 11 '22 17:10 AshishDhama

@babinderrathi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Oct 12 '22 07:10 mm-cloud-bot

/release-note-none

M-ZubairAhmed avatar Oct 12 '22 07:10 M-ZubairAhmed

/update-branch

M-ZubairAhmed avatar Oct 13 '22 10:10 M-ZubairAhmed

/update-branch

babinderrathi avatar Oct 16 '22 04:10 babinderrathi

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Oct 27 '22 01:10 mattermod

@babinderrathi can you please resolve the conflicts to continue with QA review? thanks 😄

M-ZubairAhmed avatar Oct 27 '22 05:10 M-ZubairAhmed

/update-branch

M-ZubairAhmed avatar Oct 28 '22 09:10 M-ZubairAhmed

/e2e-test

M-ZubairAhmed avatar Oct 28 '22 09:10 M-ZubairAhmed

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/255937

mattermod avatar Oct 28 '22 09:10 mattermod

last e2e cycle failed, re-running

jgilliam17 avatar Nov 01 '22 21:11 jgilliam17

/e2e-test

jgilliam17 avatar Nov 01 '22 21:11 jgilliam17

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/257220

mattermod avatar Nov 01 '22 21:11 mattermod

Test server destroyed

mm-cloud-bot avatar Nov 02 '22 01:11 mm-cloud-bot