mattermost-webapp
mattermost-webapp copied to clipboard
mattermost
MM-47072 : Migrate "components/suggestion/emoticon_provider.jsx" to Typescript
Summary
Migrate "components/suggestion/emoticon_provider.jsx" to Typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21127 JIRA: https://mattermost.atlassian.net/browse/MM-47072
Related Pull Requests
None
Screenshots
Nona
Release Note
Hello @AbhinavVihan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.
@AbhinavVihan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
I understand the commands that are listed here
Let us know if you run into any problems doing that. The type for ProviderResults in particular might be difficult without using an any right now since this code wasn't written with static typing in mind.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Hi @AbhinavVihan. Is there anything you're stuck on with this that we could help with?
@M-ZubairAhmed, Can you please check the latest commit for strict type checking. Thanks
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@michelengelen, Could you please take another look?
@AshishDhama is this ready for another round of reviews? It does look like there are still some remarks from @M-ZubairAhmed missing
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Hey there!, Thank you for your PR. Webapp is now part of mattermost monorepo now at https://github.com/mattermost/mattermost-server/tree/master/webapp Would you be interested in opening the PR over there?
The web app now lives in the webapp/channels over in https://github.com/mattermost/mattermost-server. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.
Hello there! Could you please open the PR in the mattermost-server as part of the monorepo? I will be closing this PR for now. Thank you very much for your understanding and cooperation in this matter.