[MM-38335] Prioritize results of add members to channel based on recent DMs

[ksankeerth]

Summary

• Find channels and filter DM and GM
• Sort channels as per last viewed time
• Find Userprofiles associated with channels and sort(alphabetically for GM Channenl)
• Max 10 - Userprofiles from DMs and Max 25 profiles
• 2 test cases

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/21174

Related Pull Requests

Screenshots

before	after

Before

| |

After

|

Release Note

• Enhanced user experience for adding users to channel. Users from recent DMs will be loaded for user selection and user profiles from server will be merged when they are available.

Prioritized members of recently viewed DMs/GMs when adding users to a channel

[mm-cloud-bot]

@ksankeerth: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[mattermod]

Hello @ksankeerth,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[mattermod]

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

[AshishDhama]

@ksankeerth could you please fix the lint issues

[ksankeerth]

@ksankeerth could you please fix the lint issues

Sorry for delay. I've fixed lint issues

[mm-cloud-bot]

Creating a new SpinWick test server using Mattermost Cloud.

[mm-cloud-bot]

Mattermost test server created! :tada:

Access here: https://mattermost-webapp-pr-11316.test.mattermost.cloud

Account Type	Username	Password
Admin	sysadmin	Sys@dmin123
User	user-1	User-1@123

[ksankeerth]

Thanks for the review. I'll fix them

[ksankeerth]

/update-branch

[ksankeerth]

Thanks for making those changes. There's a few other things I noticed as well when re-reviewing that I'd like changed, but that should be it then

Thanks for taking time time to review again 🙂. I have updated the branch with the suggestions.

[mm-cloud-bot]

New commit detected. SpinWick will upgrade if the updated docker image is available.

[mm-cloud-bot]

Mattermost test server updated with git commit a612298b9106b98ce25aded226323d5ceab2e3c3.

Access here: https://mattermost-webapp-pr-11316.test.mattermost.cloud

[jgilliam17]

/e2e-test

[mattermod]

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/257215

[jgilliam17]

Thanks @ksankeerth Tested manually, verified recent DMs and GMs are prioritized when adding members to channel Few test are failing, related to channel member RHS, I've pulled the specs below but you can also view the full E2E report here tests/integration/channel_settings/add_users_to_channel_spec.js tests/integration/channel/channel_members_rhs_spec.js tests/integration/channel/channel_info_rhs_spec.js

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

[AshishDhama]

@ksankeerth Please feel free to ping me for review once you are done with the e2e changes.

[AshishDhama]

@ksankeerth Do you need help with this.

[ksankeerth]

@ksankeerth Do you need help with this.

Really sorry for missing this PR. Unfortunately, I've been busy in moving to another country. Please give me a few days, try to clear this by the weekend. Sorry again.

[ksankeerth]

Thanks @ksankeerth Tested manually, verified recent DMs and GMs are prioritized when adding members to channel Few test are failing, related to channel member RHS, I've pulled the specs below but you can also view the full E2E report here tests/integration/channel_settings/add_users_to_channel_spec.js tests/integration/channel/channel_members_rhs_spec.js tests/integration/channel/channel_info_rhs_spec.js

Hi Matermost team,

I checked the above integration tests locally. The below was my observations.

** tests/integration/channel_settings/add_users_to_channel_spec.js **

• fails in master and this PR branch
• 

**tests/integration/channel/channel_members_rhs_spec.js **

• a few times it failed in this PR branch, but not able to reproduce all the times.
• when I increased timeout https://github.com/mattermost/mattermost-webapp/blob/master/e2e/cypress/tests/integration/channel/channel_members_rhs_spec.js#L126 , it doesn't fail at all

** tests/integration/channel/channel_info_rhs_spec.js **

• a few times, it failed in this PR branch, but not able to reproduce all the times

I could not think of any fixes for above its except increasing timeout. not sure how the code I added in this PR impacts these ITS. Any ideas?

Thanks!

[jgilliam17]

/e2e-test

[mattermod]

Successfully triggered E2E testing! GitLab pipeline | Test dashboard

[M-ZubairAhmed]

@AshishDhama can you verify at your end and merge please

[AshishDhama]

/update-branch

[AshishDhama]

LGMT, I will merge it after smoke testing on the test server, as soon as we can create a test server (broken right now).

[mm-cloud-bot]

Test server destroyed

[mm-cloud-bot]

Test server destroyed