mattermost-webapp
mattermost-webapp copied to clipboard
mattermost
MM-22249 : Add automatic lazy loading of syntax highlighting libraries
Summary
Load language libraries of highlight.js on demands to reduce bundle size.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/14029 Jira: https://mattermost.atlassian.net/browse/MM-22249
Related Pull Requests
No related PRs.
Screenshots
No UI changes.
Release Note
NONE
Hello @sk409,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.
Nice! Tested this out on the spinwick and can see the languages loading only once they are needed. Can also confirm the languages are split out into separate bundles.
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/254160
@jgilliam17 I commented on another PR, but just in case, What does /update-branch do? Should I merge master into this branch?
@sk409 In this case, you should merge master into this branch and resolve the conflicts. /update-branch tries to merge in master, but it aborts if there are any conflicts.
Heh, I like how both of you commenting that still triggered the bot, even when it was in a code block. That seems like it shouldn't work that way.
But yeah, if you could please merge the latest version of master into this and resolve the conflicts, that would unblock testing
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/259683
Thanks @sk409 Tested, looks good to merge. E2E report - no PR related failures. @neallred can you please approve remaining workflow and merge - thanks 🙂
