mattermost-webapp
mattermost-webapp copied to clipboard
MM-47071 : Migrate "components/suggestion/search_suggestion_list" to typescript
Summary
Migrate components/suggestion/search_suggestion_list to typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21128 JIRA: https://mattermost.atlassian.net/browse/MM-47071
Related Pull Requests
None
Screenshots
None
Release Note
NONE
Hello @AbhinavVihan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Hi @AbhinavVihan. Do you have any questions about our feedback, or is there anything we could help with on this?
hi @hmhealey, there are some functions that are being used e.g. announceLabel() from the extended class. suggestion_list.d.ts does not have these methods so typescript is giving errors in that case, if suggestion_list.d.ts is going to be imported instead of suggestion_list.jsx.
Ah, I see. In that case, you can add those to the definition in suggestion_list.d.ts
. We're going to have a similar ticket to migrate that to TypeScript as well later on, so it would help out with that if we already had type definitions for most of its fields there
/e2e-tests
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/268088
Test server destroyed