mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-T1539: E2E test to verify :man-gesturing-ok: is rendered with the correct gender

Open sk409 opened this issue 2 years ago • 11 comments

Summary

Verify 🙆‍♂️ is rendered with the correct gender

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/18163

Related Pull Requests

No related PRs.

Screenshots

No UI changes.

Release Note

NONE

sk409 avatar Oct 01 '22 06:10 sk409

Hello @sk409,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Oct 01 '22 06:10 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Oct 01 '22 06:10 mattermod

I will move spec file and change describe's name.

sk409 avatar Oct 01 '22 06:10 sk409

@sk409 Could you, please use ts instead of js, we are currently running a typescript migration campaign, and these will eventually add up to tech debt. Thanks

AshishDhama avatar Oct 01 '22 14:10 AshishDhama

@AshishDhama Thank you for your review! I renamed .js to .ts.

sk409 avatar Oct 01 '22 15:10 sk409

/e2e-test

yasserfaraazkhan avatar Oct 11 '22 05:10 yasserfaraazkhan

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/249259

mattermod avatar Oct 11 '22 05:10 mattermod

@sk409 Can you please lint errors ?

furqanmlk avatar Oct 14 '22 14:10 furqanmlk

@yasserfaraazkhan @furqanmlk I forgot to run make fix-style. I fixed style.

sk409 avatar Oct 14 '22 15:10 sk409

/update-branch

furqanmlk avatar Oct 17 '22 11:10 furqanmlk

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Oct 28 '22 01:10 mattermod

What is the review status of this PR?

sk409 avatar Nov 06 '22 04:11 sk409