mattermost-webapp
mattermost-webapp copied to clipboard
MM-47115 : Migrate "components/autocomplete_selector.jsx" to Typescript
Summary
Migration of autocomplete_selector.jsx to tsx
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21055 Fixes https://mattermost.atlassian.net/browse/MM-47115
Related Pull Requests
None
Screenshots
None
Release Note
NONE
Hello @babinderrathi,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.
@babinderrathi the CI is failing, can you please check
@babinderrathi we dont have release notes for ts migration prs
@M-ZubairAhmed Sir any other recommended changes or suggestions ?
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/update-branch
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@babinderrathi let us know if you need help to get this one through
The files .circleci/config.yml, Makefile
are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers
/update-branch
Looks like you don't have permissions to trigger this command. Only available for the PR submitter and org members
@babinderrathi thanks for the changes. It seems like something wrong happened in the last commit cc: @M-ZubairAhmed
/update-branch
/e2e-test
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/257329
Creating a new SpinWick test server using Mattermost Cloud.
Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-11198.test.mattermost.cloud
Account Type | Username | Password |
---|---|---|
Admin | sysadmin | Sys@dmin123 |
User | user-1 | User-1@123 |
Thank you @babinderrathi E2E report shows few interactive dialog tests failing, can you please take a look? Thanks 🙂
@babinderrathi can you please resolve the conflicts
New commit detected. SpinWick will upgrade if the updated docker image is available.
Mattermost test server updated with git commit c4cad5e9a149bf5253feaa39a60b84ee7f01b3d9
.
Access here: https://mattermost-webapp-pr-11198.test.mattermost.cloud
@babinderrathi can you please look at the failing e2e to see what changed in this pr that is effecting those tests