mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-47115 : Migrate "components/autocomplete_selector.jsx" to Typescript

Open babinderrathi opened this issue 1 year ago • 9 comments

Summary

Migration of autocomplete_selector.jsx to tsx

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/21055 Fixes https://mattermost.atlassian.net/browse/MM-47115

Related Pull Requests

None

Screenshots

None

Release Note

NONE

babinderrathi avatar Sep 26 '22 09:09 babinderrathi

Hello @babinderrathi,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Sep 26 '22 09:09 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Sep 26 '22 09:09 mattermod

@babinderrathi the CI is failing, can you please check

M-ZubairAhmed avatar Oct 01 '22 10:10 M-ZubairAhmed

@babinderrathi we dont have release notes for ts migration prs

M-ZubairAhmed avatar Oct 06 '22 08:10 M-ZubairAhmed

@M-ZubairAhmed Sir any other recommended changes or suggestions ?

babinderrathi avatar Oct 06 '22 08:10 babinderrathi

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Oct 17 '22 01:10 mattermod

/update-branch

M-ZubairAhmed avatar Oct 17 '22 17:10 M-ZubairAhmed

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Oct 30 '22 01:10 mattermod

@babinderrathi let us know if you need help to get this one through

M-ZubairAhmed avatar Oct 30 '22 17:10 M-ZubairAhmed

The files .circleci/config.yml, Makefile are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it. /cc @mattermost/core-security @mattermost/core-build-engineers

mattermod avatar Oct 31 '22 15:10 mattermod

/update-branch

sinansonmez avatar Oct 31 '22 15:10 sinansonmez

Looks like you don't have permissions to trigger this command. Only available for the PR submitter and org members

mattermod avatar Oct 31 '22 15:10 mattermod

@babinderrathi thanks for the changes. It seems like something wrong happened in the last commit cc: @M-ZubairAhmed

sinansonmez avatar Oct 31 '22 15:10 sinansonmez

/update-branch

M-ZubairAhmed avatar Nov 01 '22 04:11 M-ZubairAhmed

/e2e-test

M-ZubairAhmed avatar Nov 02 '22 08:11 M-ZubairAhmed

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/257329

mattermod avatar Nov 02 '22 08:11 mattermod

Creating a new SpinWick test server using Mattermost Cloud.

mm-cloud-bot avatar Nov 02 '22 13:11 mm-cloud-bot

Mattermost test server created! :tada:

Access here: https://mattermost-webapp-pr-11198.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

mm-cloud-bot avatar Nov 02 '22 13:11 mm-cloud-bot

Thank you @babinderrathi E2E report shows few interactive dialog tests failing, can you please take a look? Thanks 🙂

jgilliam17 avatar Nov 02 '22 13:11 jgilliam17

@babinderrathi can you please resolve the conflicts

M-ZubairAhmed avatar Nov 08 '22 07:11 M-ZubairAhmed

New commit detected. SpinWick will upgrade if the updated docker image is available.

mm-cloud-bot avatar Nov 09 '22 06:11 mm-cloud-bot

Mattermost test server updated with git commit c4cad5e9a149bf5253feaa39a60b84ee7f01b3d9.

Access here: https://mattermost-webapp-pr-11198.test.mattermost.cloud

mm-cloud-bot avatar Nov 09 '22 06:11 mm-cloud-bot

@babinderrathi can you please look at the failing e2e to see what changed in this pr that is effecting those tests

M-ZubairAhmed avatar Nov 09 '22 06:11 M-ZubairAhmed