mattermost-webapp
mattermost-webapp copied to clipboard
MM-20438 : Migrate 'components/channel_header_dropdown' module and associated tests to TypeScript
Summary
This PR migrates ChannelHeaderDropdown and associated tests to TypeScript.
~~I thought that sub-directories components isn't needed to fix, however, They didn't have required props.
~ added id prop to some sub-directories components and isArchived prop to MenuItemToggleMuteChannel
.
I guessed that MenuItemToggleMuteChannel
is shown when isArchived is false, otherwise hidden.
If this isArchived
fix is out of this PR scope or There is not need to do this, I will remove isArchived from MenuItemToggleMuteChannel
's callsite.~~
Ticket Link
Fixes: https://github.com/mattermost/mattermost-server/issues/16136 Fixes: https://github.com/mattermost/mattermost-server/issues/21134 Fixes : https://github.com/mattermost/mattermost-server/issues/21135 Fixes : https://github.com/mattermost/mattermost-server/issues/21137
Related Pull Requests
No related pull requests.
Screenshots
No UI changes.
Release Note
NONE
Hello @sk409,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.
I reset changes outside the scope of this PR.
/e2e-test
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/246199
@sk409 Thanks for the contribution, LGTM.
@sk409 can you please resolve the conflicts
@M-ZubairAhmed I resolved conflicts.
/e2e-test
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/247875
I resolved conflicts.
/e2e-test
Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/250739
/update-branch
Error trying to update the PR. Please do it manually.
@sk409 can you please update so I can trigger e2es again. Cycle failed last time I ran it. Edit: this PR was tested manually and works as expected on the test server
/update-branch
Error trying to update the PR. Please do it manually.
@jgilliam17 What does /update-branch do? Should I merge master into this branch?
Error trying to update the PR. Please do it manually.
/update-branch
Error trying to update the PR. Please do it manually.
@sk409 can you please rebase your branch with master
I'm sorry, I've been busy lately, but I'll start working on this tonight.
/update-branch
@jgilliam17 What does /update-branch do? Should I merge master into this branch?
Yes it rebase the upstream master to the branch
/update-branch
Mattermost test server updated with git commit 8bdbf2acfa413308cabacd0b9e4a5fddbfe9d7c3
.
Access here: https://mattermost-webapp-pr-11195.test.mattermost.cloud
Test server creation failed. See the logs for more information.
Test server creation failed. See the logs for more information.