mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

MM-20438 : Migrate 'components/channel_header_dropdown' module and associated tests to TypeScript

Open sk409 opened this issue 2 years ago • 20 comments

Summary

This PR migrates ChannelHeaderDropdown and associated tests to TypeScript.

~~I thought that sub-directories components isn't needed to fix, however, They didn't have required props. ~ added id prop to some sub-directories components and isArchived prop to MenuItemToggleMuteChannel. I guessed that MenuItemToggleMuteChannel is shown when isArchived is false, otherwise hidden. If this isArchived fix is out of this PR scope or There is not need to do this, I will remove isArchived from MenuItemToggleMuteChannel's callsite.~~

Ticket Link

Fixes: https://github.com/mattermost/mattermost-server/issues/16136 Fixes: https://github.com/mattermost/mattermost-server/issues/21134 Fixes : https://github.com/mattermost/mattermost-server/issues/21135 Fixes : https://github.com/mattermost/mattermost-server/issues/21137

Related Pull Requests

No related pull requests.

Screenshots

No UI changes.

Release Note

NONE

sk409 avatar Sep 24 '22 09:09 sk409

Hello @sk409,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Sep 24 '22 09:09 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Sep 24 '22 09:09 mattermod

I reset changes outside the scope of this PR.

sk409 avatar Sep 30 '22 16:09 sk409

/e2e-test

AshishDhama avatar Oct 01 '22 14:10 AshishDhama

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/246199

mattermod avatar Oct 01 '22 14:10 mattermod

@sk409 Thanks for the contribution, LGTM.

AshishDhama avatar Oct 01 '22 14:10 AshishDhama

@sk409 can you please resolve the conflicts

M-ZubairAhmed avatar Oct 05 '22 19:10 M-ZubairAhmed

@M-ZubairAhmed I resolved conflicts.

sk409 avatar Oct 06 '22 16:10 sk409

/e2e-test

M-ZubairAhmed avatar Oct 06 '22 16:10 M-ZubairAhmed

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/247875

mattermod avatar Oct 06 '22 16:10 mattermod

I resolved conflicts.

sk409 avatar Oct 13 '22 16:10 sk409

/e2e-test

jgilliam17 avatar Oct 14 '22 03:10 jgilliam17

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/250739

mattermod avatar Oct 14 '22 03:10 mattermod

/update-branch

jgilliam17 avatar Oct 24 '22 23:10 jgilliam17

Error trying to update the PR. Please do it manually.

mattermod avatar Oct 24 '22 23:10 mattermod

@sk409 can you please update so I can trigger e2es again. Cycle failed last time I ran it. Edit: this PR was tested manually and works as expected on the test server

jgilliam17 avatar Oct 24 '22 23:10 jgilliam17

/update-branch

M-ZubairAhmed avatar Oct 26 '22 05:10 M-ZubairAhmed

Error trying to update the PR. Please do it manually.

mattermod avatar Oct 26 '22 05:10 mattermod

@jgilliam17 What does /update-branch do? Should I merge master into this branch?

sk409 avatar Nov 01 '22 04:11 sk409

Error trying to update the PR. Please do it manually.

mattermod avatar Nov 01 '22 04:11 mattermod

/update-branch

M-ZubairAhmed avatar Nov 01 '22 04:11 M-ZubairAhmed

Error trying to update the PR. Please do it manually.

mattermod avatar Nov 01 '22 04:11 mattermod

@sk409 can you please rebase your branch with master

M-ZubairAhmed avatar Nov 01 '22 04:11 M-ZubairAhmed

I'm sorry, I've been busy lately, but I'll start working on this tonight.

sk409 avatar Nov 03 '22 03:11 sk409

/update-branch

M-ZubairAhmed avatar Nov 04 '22 06:11 M-ZubairAhmed

@jgilliam17 What does /update-branch do? Should I merge master into this branch?

Yes it rebase the upstream master to the branch

M-ZubairAhmed avatar Nov 04 '22 06:11 M-ZubairAhmed

/update-branch

M-ZubairAhmed avatar Nov 04 '22 07:11 M-ZubairAhmed

Mattermost test server updated with git commit 8bdbf2acfa413308cabacd0b9e4a5fddbfe9d7c3.

Access here: https://mattermost-webapp-pr-11195.test.mattermost.cloud

mm-cloud-bot avatar Nov 04 '22 07:11 mm-cloud-bot

Test server creation failed. See the logs for more information.

mm-cloud-bot avatar Nov 04 '22 07:11 mm-cloud-bot

Test server creation failed. See the logs for more information.

mm-cloud-bot avatar Nov 04 '22 07:11 mm-cloud-bot