mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

[MM-42029] Migrate CRT tour to use tour tip

Open AshishDhama opened this issue 2 years ago • 23 comments

Summary

Migrate CRT tour to use tour tip and remove duplicate tour manager code, remove the legacy tutorial tip

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-42029 Fixes https://github.com/mattermost/mattermost-server/issues/19803

Related Pull Requests

NA

Screenshots

NA

Release Note

-  Migrate CRT tour to use tour tip and remove duplicate tour manager code, remove the legacy tutorial tip

AshishDhama avatar Sep 09 '22 06:09 AshishDhama

/e2e-test

AshishDhama avatar Sep 21 '22 07:09 AshishDhama

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/242804

mattermod avatar Sep 21 '22 07:09 mattermod

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

mattermod avatar Sep 21 '22 07:09 mattermod

/e2e-test

AshishDhama avatar Sep 21 '22 12:09 AshishDhama

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/242862

mattermod avatar Sep 21 '22 12:09 mattermod

@pvev Thanks, yeah sure will update the pr with these.

AshishDhama avatar Sep 27 '22 09:09 AshishDhama

@pvev if you could take a look at the changes

AshishDhama avatar Sep 27 '22 16:09 AshishDhama

@AshishDhama can you please update - thanks 🙂

jgilliam17 avatar Sep 29 '22 19:09 jgilliam17

@jgilliam17 Done

AshishDhama avatar Sep 29 '22 20:09 AshishDhama

/e2e-test

jgilliam17 avatar Sep 30 '22 15:09 jgilliam17

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/245884

mattermod avatar Sep 30 '22 15:09 mattermod

Thanks @AshishDhama Tested, tour tips for CRT are working as before Few CRT e2es are failing see full report here Screen Shot 2022-09-30 at 12 05 16 PM

jgilliam17 avatar Sep 30 '22 16:09 jgilliam17

/e2e-test

AshishDhama avatar Oct 03 '22 17:10 AshishDhama

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/246776

mattermod avatar Oct 03 '22 17:10 mattermod

Thanks @AshishDhama for running the test again one test "cancel tour by clicking x" is failing - see report here I'll try to re-run the cycle, Furqan mentioned it was failing yesterday (memory issue).

jgilliam17 avatar Oct 04 '22 11:10 jgilliam17

@jgilliam17 Let me know if it still fails I will fix them

AshishDhama avatar Oct 04 '22 18:10 AshishDhama

/e2e-test

jgilliam17 avatar Oct 04 '22 23:10 jgilliam17

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/247244

mattermod avatar Oct 04 '22 23:10 mattermod

@AshishDhama 2 tests are still failing https://mattermost-cypress-report.s3.amazonaws.com/247244-060e207-onprem-ent-webapp-pr-11108-mm-ee-test:060e207/mochawesome.html Screen Shot 2022-10-04 at 8 19 45 PM

jgilliam17 avatar Oct 05 '22 00:10 jgilliam17

Test server destroyed

mm-cloud-bot avatar Oct 17 '22 11:10 mm-cloud-bot

@hmhealey it’s ready for review, @jgilliam17 have fixed the e2e

AshishDhama avatar Oct 17 '22 11:10 AshishDhama

/e2e-test

AshishDhama avatar Oct 17 '22 11:10 AshishDhama

Successfully triggered e2e testing! https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/251677

mattermod avatar Oct 17 '22 11:10 mattermod