mattermost-plugin-zoom icon indicating copy to clipboard operation
mattermost-plugin-zoom copied to clipboard

[MM-343] Updated meeting flow for new users.

Open raghavaggarwal2308 opened this issue 2 years ago • 16 comments

Summary

  • New users will get a post to select the default meeting ID when they try to start a meeting for the first time.

Screenshots

post updated_post

What to test?

  • New users are getting a post to select the default meeting ID when they try to start a meeting for the first time.
Steps to test:
  1. Create a new user on MM.
  2. Connect their zoom account.
  3. Start a zoom meeting.

Ticket Link

Fixes #343 Fixes #341

raghavaggarwal2308 avatar Mar 04 '24 15:03 raghavaggarwal2308

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 18.04%. Comparing base (009e61e) to head (b66daca).

Files Patch % Lines
server/http.go 0.00% 38 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   18.47%   18.04%   -0.44%     
==========================================
  Files           9        9              
  Lines        1510     1546      +36     
==========================================
  Hits          279      279              
- Misses       1180     1216      +36     
  Partials       51       51              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 04 '24 15:03 codecov[bot]

@raghavaggarwal2308 Can you please post some more screenshots to show the other possible states that we show the user?

mickmister avatar Mar 05 '24 13:03 mickmister

@raghavaggarwal2308 Do we automatically create the zoom meeting and take the user to the zoom meeting page after they select an option?

asaadmahmood avatar Mar 05 '24 18:03 asaadmahmood

@raghavaggarwal2308 Do we automatically create the zoom meeting and take the user to the zoom meeting page after they select an option?

@asaadmahmood Added logic to automatically redirect the user to the meeting page and yes, we automatically create the zoom meeting.

raghavaggarwal2308 avatar Mar 06 '24 10:03 raghavaggarwal2308

@raghavaggarwal2308 Can you please post some more screenshots to show the other possible states that we show the user?

@mickmister For new users: new_users.webm

For existing users: existing_users.webm

raghavaggarwal2308 avatar Mar 06 '24 10:03 raghavaggarwal2308

It seems off to me to have the zoom settings message shown during the connection process, as this makes it emphasized twice in this flow:

image

Thoughts on only showing this on meeting creation, and not account connection? @asaadmahmood

mickmister avatar Mar 08 '24 22:03 mickmister

@mickmister Fixed the review comments mentioned by you

raghavaggarwal2308 avatar Mar 11 '24 11:03 raghavaggarwal2308

The PR above has been tested for the following scenario:-

  • Every time new user gets a post to select which meeting ID before starting a meeting.

This PR is working fine for the above condition, LGTM. Approved.

AayushChaudhary0001 avatar Mar 12 '24 13:03 AayushChaudhary0001

I'm still thinking we should only show the zoom settings message on meeting creation, and not account connection. @asaadmahmood What do you think https://github.com/mattermost/mattermost-plugin-zoom/pull/344#issuecomment-1986531322?

mickmister avatar Mar 14 '24 06:03 mickmister

@mickmister @asaadmahmood Gentle reminder for the updates on this PR.

ayusht2810 avatar Mar 28 '24 08:03 ayusht2810

@mickmister @ayusht2810 Yes, I think we should only show it on meeting creation.

asaadmahmood avatar Mar 28 '24 10:03 asaadmahmood

@mickmister @asaadmahmood updated the statement. Please re-review

ayusht2810 avatar Mar 29 '24 08:03 ayusht2810

@ayusht2810 Can you show a video.

asaadmahmood avatar Mar 29 '24 11:03 asaadmahmood

@asaadmahmood Demo video for the above fix screen-capture.webm

ayusht2810 avatar Mar 29 '24 12:03 ayusht2810

LGTM

asaadmahmood avatar Mar 29 '24 12:03 asaadmahmood

@mickmister Can we merge this PR and move forward with release v1.7.1?

raghavaggarwal2308 avatar Apr 01 '24 08:04 raghavaggarwal2308

@hanzei Can we merge this PR as it is Dev and QA approved for the release 1.7.1?

ayusht2810 avatar Apr 11 '24 11:04 ayusht2810