mattermost-plugin-zoom icon indicating copy to clipboard operation
mattermost-plugin-zoom copied to clipboard

[GH-244] Update autocomplete help summary

Open jeromegrosse opened this issue 3 years ago • 8 comments

Summary

Update the auto-complete commands. In particular, states that the meeting topic argument is optional. The update is performed both in auto-complete themselves as well as the text returned by help.

Autocomplete Help Output
image image

In addition, the general autocomplete description reflects the plugin and user capabilities to connect/disconnect:

Can Connect Cannot Connect
image image

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-zoom/issues/244

jeromegrosse avatar Feb 09 '22 21:02 jeromegrosse

Hello @jeromegrosse,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Feb 09 '22 21:02 mattermod

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:

Coverage data is based on head (917c394) compared to base (a6c01ce). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #251   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         906     911    +5     
======================================
- Misses        906     911    +5     
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Feb 09 '22 21:02 codecov[bot]

@hanzei, sure! I'll do my best to update the PR today.

jeromegrosse avatar Feb 11 '22 10:02 jeromegrosse

So, there's actually already a method in that very file that checks for the condition: func (p *Plugin) canConnect(user *model.User) bool. This method depends on a User object pointer. I've thought of using it with canConnect(nil) and check within that method if user != nil. However, I don't find it super explicit. What do you all think?

jeromegrosse avatar Feb 11 '22 16:02 jeromegrosse

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

mattermod avatar Feb 22 '22 01:02 mattermod

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

mattermod avatar Mar 05 '22 01:03 mattermod

@jeromegrosse As Per The Description When i'm Disconnected then i'm Expecting this image

But i'm still getting command like this image

dipak-demansol avatar Mar 31 '22 10:03 dipak-demansol

@dipak-demansol The plugin's command autocomplete API is not able to change those descriptions per-user, so it will need to stay this way

mickmister avatar Apr 25 '22 07:04 mickmister

@jeromegrosse Sorry for the delay on your PR. Would you be open on merging master into your branch? Then your PR can get merged.

hanzei avatar Sep 18 '22 12:09 hanzei

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Oct 01 '22 01:10 mattermod

Sorry for the late reply. Let me set again the plugin on my machine and I'll solve the conflicts.

jeromegrosse avatar Oct 01 '22 13:10 jeromegrosse

Aweseome, thank you very much for the contribution @jeromegrosse

hanzei avatar Oct 09 '22 14:10 hanzei