[issue 240] zoom meeting message is not edited. #240

[sibasankarnayak]

rendered the post message instead of hardcoded text

ticket here

Fixes #240

[mattermod]

Hello @sibasankarnayak,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[codecov[bot]]

Codecov Report

Merging #248 (f3c5265) into master (a986bb4) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #248   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         900     900           
======================================
  Misses        900     900           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a986bb4...f3c5265. Read the comment docs.

[sibasankarnayak]

LGTM, but don't we want to change it also for meeting ended? (Meeting recently created probably is fine, since it is a ephemeral message that cannot be edited.

@larkox sure we can do it.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

[dipak-demansol]

tested with the 6.5.0, 6.4.0 & 6.3.0 mattermost version, LGTM for the 6.3 & 6.4, in the 6.5 mattermost version, With The PR build i'm not able to connect Zoom but with the same Config the Market place zoom is Working so need to discuss with dylan then i will give the Final Update.

[dipak-demansol]

may be i'm facing issue because of this https://github.com/mattermost/mattermost-plugin-zoom/pull/253, lets wait for merge that PR, then i'll test This again.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

[mickmister]

/update-branch

[mattermod]

We don't have permissions to update this PR, please contact the submitter to apply the update.

[mickmister]

@sibasankarnayak Please check the "let maintainers update my branch" checkbox when submitting PRs, if this is not already the case. This PR needs to be updated with master.

[mickmister]

@dipak-demansol The issue you point out is unrelated to this PR, so I think you can approve it given your message

[dipak-demansol]

@dipak-demansol The issue you point out is unrelated to this PR, so I think you can approve it given your message

Sure, i'll test it again on latest MM version and then i'll update here.

[dipak-demansol]

@sibasankarnayak after adding PR branch build i'm not able to connect with zoom account, getting this error as Could not complete the connection: [Click here to link your Zoom account.](https://my-server-URL/plugins/zoom/oauth2/connect) so i request you to add master branch latest code into this branch

[dipak-demansol]

getting those error on console

[DHaussermann]

/update-branch

[mattermod]

We don't have permissions to update this PR, please contact the submitter to apply the update.

[sibasankarnayak]

@dipak-demansol you mean there is a PR opened which need to be merge to master first and then i need to update the PR ?

[dipak-demansol]

@dipak-demansol you mean there is a PR opened which need to be merge to master first and then i need to update the PR ?

75% Yes, @DHaussermann pls provide the info about it.

[DHaussermann]

@sibasankarnayak There are issues still being investigated by myself and @mickmister for oAuth. That said, the issue @dipak-demansol is seeing no longer occurs for me in this branch here https://github.com/mattermost/mattermost-plugin-zoom/tree/pre-release-1.6.0_with-michael-fix

Is there a way to unlock testing on this as the issue seems unrelated to your PR.

[sibasankarnayak]

@sibasankarnayak There are issues still being investigated by myself and @mickmister for oAuth. That said, the issue @dipak-demansol is seeing no longer occurs for me in this branch here https://github.com/mattermost/mattermost-plugin-zoom/tree/pre-release-1.6.0_with-michael-fix

Is there a way to unlock testing on this as the issue seems unrelated to your PR.

unless and until we can not create the meeting