mattermost-plugin-playbooks icon indicating copy to clipboard operation
mattermost-plugin-playbooks copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

[MM-45052] Add error checking in insights API

Open cyrilzhang-mm opened this issue 2 years ago • 7 comments

Summary

Change some function calls in accordance with the changes in https://github.com/mattermost/mattermost-server/pull/21048

Ticket Link

Jira ticket

Checklist

  • ~~[ ] Telemetry updated~~
  • ~~[ ] Gated by experimental feature flag~~
  • ~~[ ] Unit tests updated~~

cyrilzhang-mm avatar Sep 26 '22 16:09 cyrilzhang-mm

@crspeller Any idea why the pipeline isn't picking up mm-server changes from it's corresponding branch? https://github.com/mattermost/mattermost-server/pull/21048. Focalboard pipeline is passing, https://github.com/mattermost/focalboard/pull/3876

BenCookie95 avatar Oct 03 '22 15:10 BenCookie95

@Phrynobatrachus Is our CI setup to do pick up a server branch?

crspeller avatar Oct 03 '22 15:10 crspeller

It's not. I'll try to get something setup this afternoon.

Phrynobatrachus avatar Oct 03 '22 15:10 Phrynobatrachus

It's not. I'll try to get something setup this afternoon.

Thank you!

BenCookie95 avatar Oct 03 '22 15:10 BenCookie95

Some DB tests failed with:

server/api/playbooks.go:660:26: undefined: model.GetStartOfDayForTimeRange
server/api/playbooks.go:717:26: undefined: model.GetStartOfDayForTimeRange

Does the plugin's server dependency need to be bumped once the server PR is merged?

Phrynobatrachus avatar Oct 03 '22 18:10 Phrynobatrachus

Does the plugin's server dependency need to be bumped once the server PR is merged?

Yes please note @cyrilzhang-mm .

plant99 avatar Oct 17 '22 05:10 plant99

/update-branch

cyrilzhang-mm avatar Oct 25 '22 14:10 cyrilzhang-mm