mattermost-plugin-jira icon indicating copy to clipboard operation
mattermost-plugin-jira copied to clipboard

[GH-626]: Supported filtering on comment visibility for subscriptions

Open Nityanand13 opened this issue 2 years ago • 14 comments

Summary

Added "Comment Visibility" field to subscription modal to filter notifications in the channel.

  1. When a user creates a comment in Jira then the plugin is getting notified through a webhook. Now, with this API we are getting all the information of a comment. If that particular comment has a visibility attribute that it should be visible to the users who belong to a certain group. Then notification is sent to the subscribed channel in mattermost only when that particular group is included in the subscriptions and vice versa.
  2. Apart from adding groups to which a user belongs, he can also add a group ‘visible-to-all-users’. If a particular comment has no visibility attribute, then notification is sent to the subscribed channel in mattermost only when ‘visible-to-all-users’ is present or no filter is present on the mattermost side.

Ticket Link

Fixes #626

Nityanand13 avatar Nov 28 '22 14:11 Nityanand13

Hello @Nityanand13,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Nov 28 '22 14:11 mattermod

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Dec 24 '22 01:12 mattermod

@mickmister Head up that the PR is ready for your review

hanzei avatar Feb 21 '23 09:02 hanzei

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Mar 05 '23 01:03 mattermost-build

Codecov Report

Attention: Patch coverage is 5.47945% with 69 lines in your changes missing coverage. Please review.

Project coverage is 29.41%. Comparing base (3d90500) to head (649d520). Report is 10 commits behind head on master.

:exclamation: Current head 649d520 differs from pull request most recent head 5e21750

Please upload reports for the commit 5e21750 to get more accurate results.

Files Patch % Lines
server/issue.go 0.00% 34 Missing :warning:
server/webhook_worker.go 0.00% 23 Missing :warning:
server/client.go 0.00% 7 Missing :warning:
server/subscribe.go 37.50% 3 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage   33.37%   29.41%   -3.97%     
==========================================
  Files          53       52       -1     
  Lines        8008     7861     -147     
==========================================
- Hits         2673     2312     -361     
- Misses       5112     5351     +239     
+ Partials      223      198      -25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 11 '23 10:09 codecov-commenter

@mickmister Fixed the merge conflicts and this PR is ready for review.

Kshitij-Katiyar avatar Sep 11 '23 10:09 Kshitij-Katiyar

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Oct 07 '23 01:10 mattermost-build

Also this will need to be tested on Jira Cloud and Jira Server

mickmister avatar Oct 13 '23 02:10 mickmister

@mickmister Fixed the review comments added by you.

raghavaggarwal2308 avatar Jul 01 '24 06:07 raghavaggarwal2308

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Aug 14 '24 01:08 mattermost-build