mattermost-plugin-jira icon indicating copy to clipboard operation
mattermost-plugin-jira copied to clipboard

Published 20 hours ago β€’ verified publisher icon mattermost

Create issue modal crashes when assignee is selected before switching projects

Open maisnamrajusingh opened this issue 2 years ago β€’ 6 comments

Summary

Fixes the issue whenever user selects a project , task and then an asignee and then switches projects -> tasks again which causes the app to crash

Ticket Link

https://github.com/mattermost/mattermost-plugin-jira/issues/819

maisnamrajusingh avatar Mar 08 '22 05:03 maisnamrajusingh

Hello @maisnamrajusingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Mar 08 '22 05:03 mattermod

@mickmister please ignore this until @dipak-demansol has done the qa on this.

maisnamrajusingh avatar Mar 08 '22 05:03 maisnamrajusingh

Codecov Report

Merging #848 (a8da80b) into master (f986c15) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   31.46%   31.46%           
=======================================
  Files          49       49           
  Lines        5982     5982           
=======================================
  Hits         1882     1882           
  Misses       3911     3911           
  Partials      189      189

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update f986c15...a8da80b. Read the comment docs.

codecov-commenter avatar Mar 14 '22 04:03 codecov-commenter

its LGTM but i'll test it again on the browser & desktop app when the dev review is done.

dipak-demansol avatar Mar 16 '22 06:03 dipak-demansol

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Apr 21 '22 01:04 mattermod

@mickmister could you take a look ? I feel this is good to go.

maisnamrajusingh avatar Apr 24 '22 03:04 maisnamrajusingh

Closing due to https://github.com/mattermost/mattermost-plugin-jira/pull/848#discussion_r995978868

mickmister avatar Oct 14 '22 17:10 mickmister