mattermost-plugin-jira
mattermost-plugin-jira copied to clipboard
[issue 507 & 699] Add support for DM subscriptions for Watchers and Reporter
adding watching and reporter notification feature for jira
ticket here fixes #507 fixes #699
Hello @sibasankarnayak,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Codecov Report
Merging #840 (9f748c1) into master (f986c15) will decrease coverage by
0.35%
. The diff coverage is27.42%
.
@@ Coverage Diff @@
## master #840 +/- ##
==========================================
- Coverage 31.46% 31.10% -0.36%
==========================================
Files 49 49
Lines 5982 6186 +204
==========================================
+ Hits 1882 1924 +42
- Misses 3911 4073 +162
Partials 189 189
Impacted Files | Coverage Δ | |
---|---|---|
server/client.go | 8.64% <0.00%> (-0.30%) |
:arrow_down: |
server/command.go | 16.80% <0.00%> (-0.40%) |
:arrow_down: |
server/user_cloud.go | 0.00% <0.00%> (ø) |
|
server/user_server.go | 8.08% <0.00%> (-0.53%) |
:arrow_down: |
server/webhook.go | 27.10% <0.00%> (-3.75%) |
:arrow_down: |
server/webhook_worker.go | 0.00% <0.00%> (ø) |
|
server/issue.go | 28.76% <13.33%> (-2.97%) |
:arrow_down: |
server/webhook_parser.go | 85.03% <71.42%> (-0.19%) |
:arrow_down: |
server/settings.go | 80.43% <86.66%> (+0.43%) |
:arrow_up: |
server/user.go | 29.37% <100.00%> (+3.78%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f986c15...9f748c1. Read the comment docs.
@mickmister can you check currently notification will be triggered for watching feature.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
It seems, that the MR is nearly complete. @sibasankarnayak could you please agree with @mickmister on the pending changes? This change would really help me. Thx
Closing in favor of https://github.com/mattermost/mattermost-plugin-jira/pull/872