[issue 773] Jira's autolink should support issue links that contain a comment link in the URL

[sibasankarnayak]

added autolink for link that contain a comment link

ticket here

Fixes #773

[mattermod]

Hello @sibasankarnayak,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[codecov-commenter]

Codecov Report

Merging #839 (74b501c) into master (c6a6f00) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
- Coverage   34.81%   34.78%   -0.03%     
==========================================
  Files          52       52              
  Lines        5949     5954       +5     
==========================================
  Hits         2071     2071              
- Misses       3666     3671       +5     
  Partials      212      212              

Impacted Files	Coverage Δ
server/plugin.go	15.84% <0.00%> (-0.45%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6a6f00...74b501c. Read the comment docs.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

[hanzei]

Blocked by https://github.com/mattermost/mattermost-plugin-autolink/pull/175

[sibasankarnayak]

@mickmister as discussed over call , confirmed that autolink feature works in master and kept the shorthand and added the project independent regex for ticket url and comment url

[mickmister]

@dipak-demansol When you review this, please test the plugin upgrade path. Meaning:

• Install the previous version of the Jira plugin
• Install Jira instance with several projects
• Note the autolink entries that were created
• Install this version of the plugin
• Note the autolink entries. Please post the result here.
• Test behavior of posting ticket links with the form:
  • https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210
  • https://mattermost.atlassian.net/browse/MM-12345
  • MM-12345 (should only work with Jira Cloud)

Please test with Jira Cloud and Jira Server

[dipak-demansol]

@sibasankarnayak @mickmister i can still see the same output before and after installing the PR build.

steps 1) installed the market jira build. 2) Connected with the jira instance. (autolink was already Configured) 3) paste the link of the comment from that same instance, pls see the attachment image. 4) installed the PR build and paste again the same link and got the same output, pls see the attachment image.

[mickmister]

@sibasankarnayak @dipak-demansol Can you please get together and try to debug the issue @dipak-demansol is seeing?

[sibasankarnayak]

talled the market jira build.

I see you install the market jira build that doesn't contain the solution , try installing this PR and then do test with required step.

[DHaussermann]

@sibasankarnayak I have also tested this and see that the latest commit on the PR does not solve the issue. See screen below.

Regarding your comment above:

1. Reinstalling the Jira instance does not resolve the issue and autolink behavior
2. Even still - Is there a possible solution that does not requires re-installing the plugin?

[dipak-demansol]

@DHaussermann i Used the same build and it worked for me this time, i just removed the jira instance and connected again but you and me we also did the same thing and it was not worked for us so need to investigate that what was the exact reason because of that the same build previously not worked for us. its working still without knowing the cause of the issue i can't pass this.

attacking the screenshot as its now worked for me,

[DEM-1 (comment)](https://demansol.atlassian.net/browse/DEM-1?focusedCommentId=10257) server is https://dkh-ha-20.test.mattermost.cloud/