mattermost-plugin-jira icon indicating copy to clipboard operation
mattermost-plugin-jira copied to clipboard

Add per-subscription "Hide issue descriptions and comments" setting

Open levb opened this issue 4 years ago • 8 comments

https://github.com/mattermost/mattermost-plugin-jira/pull/503 added the setting as a plugin-wide config option.

We should add a per-subscription setting as well.

@asaadmahmood will provide the UX, and the priority order (i.e. should the plugin config override, or be overridden by subscription-specific settings)

levb avatar Mar 19 '20 14:03 levb

@levb We can place the checkbox here, and this should override the system console setting, as there may be cases where we want to do something different than the global setting, and that's how various other settings work in the system. We have a global default, and then we have the ability to override that on a per channel basis (mentions as an example).

Artboard

asaadmahmood avatar Apr 28 '20 08:04 asaadmahmood

Thanks for the UX description, @asaadmahmood! I am removing updating the issue as an Up For Grabs ticket after getting your spec.

jfrerich avatar May 26 '20 18:05 jfrerich

Hi, #783 needs to be merged first.

sanjaydemansol avatar Jul 31 '21 05:07 sanjaydemansol

@sanjaydemansol The two features both use the subscriptions feature, but I don't think adding a new setting to the subscription needs to wait for the subscription template feature to be complete. No interfering data model changes are part of the template feature's PR.

I think this issue can be worked on in parallel with the linked PR https://github.com/mattermost/mattermost-plugin-jira/pull/783. @sanjaydemansol @jfrerich What do you think?

mickmister avatar Aug 10 '21 06:08 mickmister

I agree this feature can be worked on in parallel

jfrerich avatar Aug 12 '21 19:08 jfrerich

@mickmister I suggested because if we work on this issue in parallel, this feature won't be a part of subscription templates.

sanjaydemansol avatar Aug 20 '21 04:08 sanjaydemansol

@sanjaydemansol I still think it can be worked on in parallel. Whichever PR gets merged first will have to incorporate the other PR's changes. I don't think it will be difficult to handle that situation

mickmister avatar Aug 23 '21 15:08 mickmister

This is not a priory. Unassigning @jupriano for now.

hanzei avatar Jan 04 '22 20:01 hanzei

Closing issues due to inactivity. This issue can be re-opened with more interest from our community.

wiersgallak avatar Jun 14 '23 01:06 wiersgallak