mattermost-plugin-jira icon indicating copy to clipboard operation
mattermost-plugin-jira copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

/jira transition should use transition name instead of state

Open gpr opened this issue 5 years ago • 9 comments

The state is unique but you may have several transitions to a given state (typically to move to a state by changing automatically some fields).

State1 -- transition1 --> State2
State1 -- transition2 --> State2

In such case the command /jira transition ISSUE-1 State2 does not work and we get the following error:

please be more specific, "State2" matched several states: "State2, State2"

It seems reasonable to use the transition name instead of the destination state name.

gpr avatar Oct 11 '19 09:10 gpr

Hi @gpr I'd like to work on this.

qiell avatar Oct 14 '19 17:10 qiell

Hey @qiell Thanks for taking this on, I've removed the "up for grabs" label.

aaronrothschild avatar Oct 15 '19 15:10 aaronrothschild

@qiell Are you still interested in working on this ticket?

levb avatar Nov 12 '19 13:11 levb

Hi @levb, Sorry for my late response. I was in no network zone from last 20 days. I'll work on this and raise a PR ASAP.

Thank you. :)

qiell avatar Nov 12 '19 18:11 qiell

@jfrerich I believe the /jira transition functionality is more or less being replaced by the new transition functionality being introduced to /jira view https://github.com/mattermost/mattermost-plugin-jira/pull/454. I'm not sure if this ticket is still relevant

Edit: With that in mind, we should also make sure that the problem proposed in this ticket is still addressed. We should be using transitions and not states. It looks like that PR is indeed using transitions. Though I don't think any code was changed to use the transitions instead of states...

mickmister avatar Feb 11 '20 04:02 mickmister

@mickmister, thanks for letting me know. If the plan is to remove the /jira transition command, then I'd agree we can also close this issue.

jfrerich avatar Feb 11 '20 14:02 jfrerich

If the plan is to remove the /jira transition command, then I'd agree we can also close this issue.

@aaronrothschild Since the /jira view command will now support transitioning an issue by selecting the transition with a select box, do you agree that we should retire the /jira transition command?

mickmister avatar Feb 12 '20 06:02 mickmister

I don't understand the logic here. Why do I need to view an issue? Why retire the transition command?

levb avatar Feb 12 '20 12:02 levb

Let's complete the spec for this ticket.

Although we will have the ability to transition an issue from /jira view with #454, let's leave the /jira transistion command and keep the original scope to use transition names instead of state names. Any objections?

jfrerich avatar Apr 06 '20 14:04 jfrerich

Closing issues due to inactivity. This issue can be re-opened with more interest from our community.

wiersgallak avatar Jun 14 '23 01:06 wiersgallak