mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

Convert files related to redux from js to ts

Open raghavaggarwal2308 opened this issue 1 year ago • 6 comments
trafficstars

Summary

  • Convert files related to redux from js to ts
  • Removed some unused code
  • Fixed CSS warnings

What to test?

  • Complete testing of the plugin.

raghavaggarwal2308 avatar Feb 16 '24 13:02 raghavaggarwal2308

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.02%. Comparing base (191a11a) to head (7eaf225). Report is 7 commits behind head on master.

:exclamation: Current head 7eaf225 differs from pull request most recent head 98b9f75

Please upload reports for the commit 98b9f75 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   34.02%   34.02%           
=======================================
  Files          22       22           
  Lines        4021     4021           
=======================================
  Hits         1368     1368           
  Misses       2515     2515           
  Partials      138      138           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 16 '24 13:02 codecov[bot]

@mickmister Fixed the review comments. Please re-review.

ayusht2810 avatar Mar 26 '24 16:03 ayusht2810

@mickmister Gentle reminder for the re-review

ayusht2810 avatar Apr 18 '24 07:04 ayusht2810

@mickmister Fixed the review comments added by you

raghavaggarwal2308 avatar Jun 25 '24 20:06 raghavaggarwal2308

@mickmister Implemented the suggestions. Please have a look

Kshitij-Katiyar avatar Jul 09 '24 08:07 Kshitij-Katiyar

@mickmister @wiggin77 Updated the suggestions, please have a look.

Kshitij-Katiyar avatar Jul 10 '24 13:07 Kshitij-Katiyar