mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

[MM-147] Updated log statements

Open raghavaggarwal2308 opened this issue 1 year ago • 7 comments

Summary

  • Updated log statements
  • Removed unnecessary logs

raghavaggarwal2308 avatar Jan 18 '24 10:01 raghavaggarwal2308

Codecov Report

Attention: Patch coverage is 18.18182% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 33.40%. Comparing base (53b10f3) to head (ad68089).

Files Patch % Lines
server/plugin.go 23.70% 101 Missing and 2 partials :warning:
server/api.go 0.00% 40 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   34.02%   33.40%   -0.62%     
==========================================
  Files          22       22              
  Lines        4021     4185     +164     
==========================================
+ Hits         1368     1398      +30     
- Misses       2515     2647     +132     
- Partials      138      140       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 18 '24 10:01 codecov[bot]

@mickmister Gentle reminder for review

raghavaggarwal2308 avatar Jan 31 '24 09:01 raghavaggarwal2308

I'm not sure if we should go through with this logging approach in general. @hanzei What are your thoughts on this?

mickmister avatar Mar 14 '24 05:03 mickmister

The diff looks off. Maybe the PR needs to get rebased onto verbose-logging-for-token-debugging?

hanzei avatar Mar 15 '24 13:03 hanzei

@hanzei The branch MM-147 is in sync with the base branch. We have removed some unnecessary log statements from the code in this PR.

raghavaggarwal2308 avatar Mar 18 '24 09:03 raghavaggarwal2308

@raghavaggarwal2308 We can have this PR point to master instead

mickmister avatar Mar 27 '24 19:03 mickmister

@mickmister updated

raghavaggarwal2308 avatar Mar 28 '24 07:03 raghavaggarwal2308