[GH-326] Added subscription flag for filtering out confidential issues, and disallow guests from creating subscriptions

[Kshitij-Katiyar]

trafficstars

Summary

• Added an additional flag for confidential issues in the subscription slash command.
• Added the check that guest users cannot create a subscription.

Issue

• Issue #326

[mattermost-build]

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 33.99%. Comparing base (98fdf4f) to head (bfb8f9c). Report is 11 commits behind head on master.

Files	Patch %	Lines
server/subscription/subscription.go	0.00%	2 Missing :warning:
server/webhook/issue.go	60.00%	1 Missing and 1 partial :warning:
server/command.go	83.33%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   33.40%   33.99%   +0.59%     
==========================================
  Files          22       22              
  Lines        3979     3992      +13     
==========================================
+ Hits         1329     1357      +28     
+ Misses       2519     2499      -20     
- Partials      131      136       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

[mickmister]

@Kshitij-Katiyar Heads up that there are conflicts to resolve here

[Kshitij-Katiyar]

@mickmister Fixed the merge conflicts

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

[hanzei]

@DHaussermann The PR is ready for your review

[mattermost-build]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

[mickmister]

@Kshitij-Katiyar Heads up that there are conflicts to resolve here

[hanzei]

@Kshitij-Katiyar gentle reminder to resolve the conflicts

[ayusht2810]

@hanzei resolved the conflicts.

[AayushChaudhary0001]

@raghavaggarwal2308 While testing this PR, none of the above conditions were found working. The guest user on MM was able to create a subscription and also there wasn't any flag for confidential issues in subscription slash command. Please go-through this once.

[raghavaggarwal2308]

@raghavaggarwal2308 While testing this PR, none of the above conditions were found working. The guest user on MM was able to create a subscription and also there wasn't any flag for confidential issues in subscription slash command. Please go-through this once.

@AayushChaudhary0001

1. The flag is added in the "--features" section while creating a subscription.
2. The user who has guest access to a Gitlab project cannot create a subscription on MM.