mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

Use ReactDOM webpack external

Open mickmister opened this issue 3 years ago • 1 comments
trafficstars

Summary

This plugin currently doesn't use react-dom, but I'm adding this here in case we add a library like react-select in the future.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-47046

mickmister avatar Sep 21 '22 04:09 mickmister

Codecov Report

Base: 28.48% // Head: 28.48% // No change to project coverage :thumbsup:

Coverage data is based on head (b0be6b6) compared to base (2c3003b). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   28.48%   28.48%           
=======================================
  Files          20       20           
  Lines        2619     2619           
=======================================
  Hits          746      746           
  Misses       1789     1789           
  Partials       84       84           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 21 '22 04:09 codecov[bot]