mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

Add UserHasBeenDeactivated hook to disconnect user

Open MatthewDorner opened this issue 3 years ago • 5 comments
trafficstars

Summary

Implement UserHasBeenDeactivated plugin hook to disconnect a user when that user is deactivated.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-gitlab/issues/287

Maybe obvious, but in order to test, you have add to the plugin's go.mod: replace github.com/mattermost/mattermost-server/v6 v6.5.0 => ../mattermost-server to point to your local copy of server with the changes from my server PR: https://github.com/mattermost/mattermost-server/pull/20894

MatthewDorner avatar Aug 27 '22 03:08 MatthewDorner

Hello @MatthewDorner,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Aug 27 '22 03:08 mattermod

Codecov Report

Patch coverage has no change and project coverage change: -0.04% :warning:

Comparison is base (835b440) 32.94% compared to head (ea61627) 32.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   32.94%   32.91%   -0.04%     
==========================================
  Files          22       22              
  Lines        4013     4017       +4     
==========================================
  Hits         1322     1322              
- Misses       2560     2564       +4     
  Partials      131      131              
Files Changed Coverage Δ
server/plugin.go 14.39% <0.00%> (-0.09%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '22 03:08 codecov[bot]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Sep 07 '22 01:09 mattermod

@mickmister @ashishbhate Updated here to match the updated plugin hook function signature in the server PR.

MatthewDorner avatar Sep 16 '22 01:09 MatthewDorner

Maybe obvious, but in order to test, you have add to the plugin's go.mod: replace github.com/mattermost/mattermost-server/v6 v6.5.0 => ../mattermost-server to point to your local copy of server with the changes from my server PR: https://github.com/mattermost/mattermost-server/pull/20894

Note that this means we have to adjust this project's go.mod to point the appropriate server version after the new server version is released

mickmister avatar Sep 19 '22 03:09 mickmister

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Oct 04 '22 01:10 mattermod

@DHaussermann Gentle reminder to review this PR

hanzei avatar Feb 22 '23 21:02 hanzei

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Mar 05 '23 01:03 mattermost-build

/update-branch

DHaussermann avatar Apr 26 '23 14:04 DHaussermann

https://github.com/mattermost/mattermost-plugin-gitlab/pull/393 needs to get merged first.

hanzei avatar Aug 21 '23 11:08 hanzei

Tested and confirmed that users who get deactivated also disconnect from GitLab. Ready for merging :rocket:

hanzei avatar Aug 30 '23 08:08 hanzei

Thanks, @MatthewDorner, for the contribution. Sorry, it took so long.

hanzei avatar Aug 30 '23 08:08 hanzei