mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

GitLab plugin Icon Updated

Open varghesejose2020 opened this issue 3 years ago • 3 comments

GitLab new Icon Updated

Summary

Ticket Link

varghesejose2020 avatar Jun 12 '22 07:06 varghesejose2020

Hello @varghesejose2020,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Jun 12 '22 07:06 mattermod

Codecov Report

Patch and project coverage have no change.

Comparison is base (21beec5) 32.27% compared to head (7f3c0f1) 32.27%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   32.27%   32.27%           
=======================================
  Files          21       21           
  Lines        3433     3433           
=======================================
  Hits         1108     1108           
  Misses       2215     2215           
  Partials      110      110

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 12 '22 07:06 codecov[bot]

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Jul 02 '22 01:07 mattermod

@DHaussermann Gentle reminder to review this PR

hanzei avatar Feb 22 '23 21:02 hanzei

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Mar 05 '23 01:03 mattermost-build

@varghesejose2020 sorry for the delay. We are now getting organized for another GitLab release and would love to include your image update.

I have tested and can confirm the icon is updated as expected. 👍

I do have 1 point here. Is it possible to also update the the .png used as the GitLab bot profile image? Let me know if this is something you can still help with or if we should open a separate issue for this?

The marketplace icon may need its own change in the Marketplace repo. @hanzei is this correct or is the marketplace able to pull the udted image from the plugin somehow?

DHaussermann avatar Mar 07 '23 19:03 DHaussermann

Hi @DHaussermann GitLab bot Profile image updated with. . png file

varghesejose2020 avatar Mar 11 '23 14:03 varghesejose2020

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Mar 22 '23 01:03 mattermost-build

Hi @varghesejose2020 I took another looks at this.

The .png is updated and it looks like the resolution of the image get's scaled down as needed so it's perfectly fine that the new one is smaller. However it appears small in the Mattermost UI as well despite being the same size in the DOM. image

This seems to be simply because there is significantly more white space as paert of the image. image

Is this something you're easily able to adjust?

DHaussermann avatar Mar 28 '23 18:03 DHaussermann

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Apr 30 '23 01:04 mattermost-build

Closing as inactive. Still, thanks for the contribution @varghesejose2020 :+1:

hanzei avatar Nov 29 '23 12:11 hanzei