mattermost-plugin-gitlab
mattermost-plugin-gitlab copied to clipboard
mattermost
[GH-61]: Add tooltip for pull request and issue links
Summary
This PR adds a tooltip for the pull requests and issue links.
Screenshots:
Issue tooltip:
Merge request tooltip:
Ticket Link
Fixes https://github.com/mattermost/mattermost-plugin-gitlab/issues/61
Hello @shivamjosh,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Codecov Report
Attention: 46 lines in your changes are missing coverage. Please review.
Comparison is base (
c56accf) 33.61% compared to head (424eec9) 33.25%.
| Files | Patch % | Lines |
|---|---|---|
| server/api.go | 4.16% | 46 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 33.61% 33.25% -0.36%
==========================================
Files 22 22
Lines 3924 3972 +48
==========================================
+ Hits 1319 1321 +2
- Misses 2474 2520 +46
Partials 131 131
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
The RC for this release is running on community, though I'm not seeing the link tooltip working for our self-hosted version of GitLab. @avas27JTG @raghavaggarwal2308 Any ideas why this might be the case? There is no HTTP request being made by the frontend to fetch the tooltip information. No errors in the browser console either.
@mickmister The release candidate v1.8.0-rc1 was missing the link_tooltip component therefore the tooltip was not visible. I have synced the bump version PR with the latest master, and the tooltip is working fine now.
