mattermost-plugin-gitlab
mattermost-plugin-gitlab copied to clipboard
[GH-61]: RHS Support
Summary
Added functionality to displays the details of users's open merge requests, merge requests needing review, assignments and unreads (todos) in the right-hand sidebar onclick of the buttons(respective icons) in the left-hand sidebar/team sidebar.
- Created a new "SidebarRight" component and registered it as a RHS component and stored the "showRHSPluginAction" action in redux to use whenever needed to display the sidebar.
- Stored the state of RHS in redux to display the different possible views.
- Created API endpoint to fetch additional details of merge requests to display the merge request's commit status and number of approvals.
- Added warning icon after merge request title if there are conflicts in the merge request.
Screenshots
-
RHS with open merge requests

-
RHS with unreads (todos)

-
RHS with no items to display

Ticket
Fixes #61 (Adding RHS support and Improve RHS UI and content)
Hello @raghavaggarwal2308,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
Codecov Report
Patch coverage: 6.66% and project coverage change: -0.14 :warning:
Comparison is base (
2534105) 32.40% compared to head (3336353) 32.27%.
Additional details and impacted files
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 32.40% 32.27% -0.14%
==========================================
Files 21 21
Lines 3419 3433 +14
==========================================
Hits 1108 1108
- Misses 2201 2215 +14
Partials 110 110
| Impacted Files | Coverage Δ | |
|---|---|---|
| server/api.go | 23.14% <6.66%> (-0.69%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
/check-cla
Merged the following changes is this PR:
- Created API endpoint to fetch additional details of merge requests to display the merge request's commit status and number of approvals.
- Added warning icon after merge request title if there are conflicts in the merge request.
Ticket
Fixes #61 (Improve RHS UI and content)
@pvev Fixed the review-fixes you mentioned.
@pvev Fixed the review-fixes you mentioned.
awesome @raghavaggarwal2308 . Will give another extra look. Thanks!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@mickmister Fixed the review-fixes you mentioned.
I thought about the localization piece some more. Let's remove it from this PR, partially to narrow the scope a bit, but also because it is a larger task to take on with all of the plugin projects. I'd like to do it "correctly" by hooking into the webapp's i18n framework provided to the plugins. Introducing that in this PR seems unnecessary. Let's just go with having the strings hardcoded for now.
@mickmister Fixed the review fixes you mentioned
@mickmister Gentle reminder for re-review
@mickmister Gentle reminder for re-review
@mickmister Gentle reminder for re-review
@mickmister Gentle reminder for re-review
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@mickmister @spirosoik Gentle reminder for review
@mickmister @cwarnermm fixed the review fixes you mentioned.
@mickmister Made some changes in the code. I hope that answers your questions.
@raghavaggarwal2308 Heads up that there are conflicts that need to be resolved
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@raghavaggarwal2308 Please make sure these changes are compatible with the chanegs from https://github.com/mattermost/mattermost-plugin-gitlab/pull/333
@mickmister Tested, the changes are compatible with the changes of PR #333
@DHaussermann This is ready for QA review
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/update-branch
We don't have permissions to update this PR, please contact the submitter to apply the update.
@DHaussermann Gentle reminder to review the PR
Hi @raghavaggarwal2308 This is looking good! I only have 1 small thing.
Is it easy to add 1 whitespace character between the end of the link and the beginning of the remaining data where the project name is?


@DHaussermann Fixed 👍🏽 (Added whitespace character between the end of the link and the beginning of the remaining data)