mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

Add Merge Request Approval Subscription

Open shakeandbakebaby opened this issue 3 years ago • 2 comments

When a merge request gets approved it is an indicator to go do something else. This request is for adding the ability to subscribe to merge request is approved or unapproved. Current work around is to have a webhook post the change and not the gitlab mattermost plugin.

shakeandbakebaby avatar Mar 15 '22 13:03 shakeandbakebaby

I would like to work on this.

MatthewDorner avatar May 27 '22 07:05 MatthewDorner

The merge request approval and unapproval are still MergeEvent type webhook events, so there would be no additional subscription feature. You'd just add the code in webhook/merge_request.go to handle the approved and unapproved actions and generate the correct DM and Channel posts. That sound right?

MatthewDorner avatar Jun 15 '22 19:06 MatthewDorner