mattermost-plugin-gitlab icon indicating copy to clipboard operation
mattermost-plugin-gitlab copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

#213 Add command to run a new CI Build (Continuation of PR #224)

Open lufty-demansol opened this issue 3 years ago • 11 comments

This PR is forked of #224 to continue the work.

lufty-demansol avatar Mar 09 '22 01:03 lufty-demansol

Hello @lufty-demansol,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

mattermod avatar Mar 09 '22 01:03 mattermod

Codecov Report

Merging #280 (3c9806a) into master (aec8208) will decrease coverage by 0.21%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   28.59%   28.37%   -0.22%     
==========================================
  Files          20       20              
  Lines        2595     2615      +20     
==========================================
  Hits          742      742              
- Misses       1769     1789      +20     
  Partials       84       84
Impacted Files Coverage Δ
server/command.go 25.05% <0.00%> (-1.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aec8208...3c9806a. Read the comment docs.

codecov[bot] avatar Mar 09 '22 01:03 codecov[bot]

@hanzei @iomodo can you give approval to @lufty-demansol as he is not able to run the CI here.

maisnamrajusingh avatar Mar 15 '22 05:03 maisnamrajusingh

@lufty-demansol Heads up that CI is failing with: https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-gitlab/705/workflows/694a0a2e-a186-4d51-9555-a756f1cef82b/jobs/2214/parallel-runs/0/steps/0-103

hanzei avatar Mar 15 '22 19:03 hanzei

there is panic message that I don't quite understand yet when running make test

goroutine 19 [select]:
net/http.(*Transport).getConn(0xc0003fe780, 0xc0003fcb80, {{}, 0x0, {0xc0001c2900, 0x5}, {0xc000410812, 0xe}, 0x0})
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/transport.go:1372 +0xa45
net/http.(*Transport).roundTrip(0xc0003fe780, 0xc0001f8800)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/transport.go:581 +0xcdf
net/http.(*Transport).RoundTrip(0xc0001f8800, 0x1692c00)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/roundtrip.go:18 +0x37
net/http.send(0xc0001f8800, {0x1692c00, 0xc0003fe780}, {0x0, 0x108ff20, 0x0})
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:252 +0x93f
net/http.(*Client).send(0xc000406ba0, 0xc0001f8800, {0x12a75ce, 0x14, 0x0})
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:176 +0x158
net/http.(*Client).do(0xc000406ba0, 0xc0001f8800)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:725 +0x1087
net/http.(*Client).Do(...)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:593
github.com/xanzy/go-gitlab.(*Client).configureLimiter(0xc000240800, {0x169b4c8, 0xc000237380})
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/gitlab.go:479 +0x185
github.com/xanzy/go-gitlab.(*Client).Do.func1()
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/gitlab.go:737 +0xc5
sync.(*Once).doSlow(0xc000240814, 0xc00020ba50)
	/usr/local/Cellar/go/1.17.5/libexec/src/sync/once.go:68 +0x128
sync.(*Once).Do(0xc000240814, 0x0)
	/usr/local/Cellar/go/1.17.5/libexec/src/sync/once.go:59 +0x47
github.com/xanzy/go-gitlab.(*Client).Do(0xc000240800, 0xc0003d6790, {0x1546d20, 0xc00027e380})
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/gitlab.go:737 +0xc5
github.com/xanzy/go-gitlab.(*PipelinesService).CreatePipeline(0xc00018a6d8, {0x1537d20, 0xc0003d6560}, 0x2, {0xc00019bcb8, 0x1, 0x1})
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/pipelines.go:290 +0x1a6
github.com/mattermost/mattermost-plugin-gitlab/server/gitlab.(*gitlab).TriggerNewBuildPipeline(0x189dbd0, 0xc000050de8, {0x15cedd9, 0x8}, {0x15cbf38, 0x6})
	/Users/arknable/Documents/Project/lufty-demansol/mattermost-plugin-gitlab/server/gitlab/api.go:427 +0x3c5
github.com/mattermost/mattermost-plugin-gitlab/server/gitlab.TestTriggerNewBuildPipeline(0xc000276820)
	/Users/arknable/Documents/Project/lufty-demansol/mattermost-plugin-gitlab/server/gitlab/api_test.go:23 +0x125
testing.tRunner(0xc000276820, 0x1619e08)
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1259 +0x230
created by testing.(*T).Run
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1306 +0x727

lufty-demansol avatar Mar 21 '22 06:03 lufty-demansol

there is panic message that I don't quite understand yet when running make test

goroutine 19 [select]:
net/http.(*Transport).getConn(0xc0003fe780, 0xc0003fcb80, {{}, 0x0, {0xc0001c2900, 0x5}, {0xc000410812, 0xe}, 0x0})
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/transport.go:1372 +0xa45
net/http.(*Transport).roundTrip(0xc0003fe780, 0xc0001f8800)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/transport.go:581 +0xcdf
net/http.(*Transport).RoundTrip(0xc0001f8800, 0x1692c00)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/roundtrip.go:18 +0x37
net/http.send(0xc0001f8800, {0x1692c00, 0xc0003fe780}, {0x0, 0x108ff20, 0x0})
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:252 +0x93f
net/http.(*Client).send(0xc000406ba0, 0xc0001f8800, {0x12a75ce, 0x14, 0x0})
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:176 +0x158
net/http.(*Client).do(0xc000406ba0, 0xc0001f8800)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:725 +0x1087
net/http.(*Client).Do(...)
	/usr/local/Cellar/go/1.17.5/libexec/src/net/http/client.go:593
github.com/xanzy/go-gitlab.(*Client).configureLimiter(0xc000240800, {0x169b4c8, 0xc000237380})
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/gitlab.go:479 +0x185
github.com/xanzy/go-gitlab.(*Client).Do.func1()
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/gitlab.go:737 +0xc5
sync.(*Once).doSlow(0xc000240814, 0xc00020ba50)
	/usr/local/Cellar/go/1.17.5/libexec/src/sync/once.go:68 +0x128
sync.(*Once).Do(0xc000240814, 0x0)
	/usr/local/Cellar/go/1.17.5/libexec/src/sync/once.go:59 +0x47
github.com/xanzy/go-gitlab.(*Client).Do(0xc000240800, 0xc0003d6790, {0x1546d20, 0xc00027e380})
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/gitlab.go:737 +0xc5
github.com/xanzy/go-gitlab.(*PipelinesService).CreatePipeline(0xc00018a6d8, {0x1537d20, 0xc0003d6560}, 0x2, {0xc00019bcb8, 0x1, 0x1})
	/Users/arknable/Documents/GOPATH/pkg/mod/github.com/xanzy/[email protected]/pipelines.go:290 +0x1a6
github.com/mattermost/mattermost-plugin-gitlab/server/gitlab.(*gitlab).TriggerNewBuildPipeline(0x189dbd0, 0xc000050de8, {0x15cedd9, 0x8}, {0x15cbf38, 0x6})
	/Users/arknable/Documents/Project/lufty-demansol/mattermost-plugin-gitlab/server/gitlab/api.go:427 +0x3c5
github.com/mattermost/mattermost-plugin-gitlab/server/gitlab.TestTriggerNewBuildPipeline(0xc000276820)
	/Users/arknable/Documents/Project/lufty-demansol/mattermost-plugin-gitlab/server/gitlab/api_test.go:23 +0x125
testing.tRunner(0xc000276820, 0x1619e08)
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1259 +0x230
created by testing.(*T).Run
	/usr/local/Cellar/go/1.17.5/libexec/src/testing/testing.go:1306 +0x727

well CI passed so I guess it's not meant to be executed in local

lufty-demansol avatar Mar 21 '22 08:03 lufty-demansol

@hanzei please take a look

lufty-demansol avatar Apr 12 '22 12:04 lufty-demansol

@lufty-demansol Heads up that you need to merge master

hanzei avatar May 02 '22 10:05 hanzei

@lufty-demansol Heads up that you need to merge master

@hanzei , I have merged with master on this commit 9bf44b35410603bc5c6a302fef17040a41a8c265

lufty-demansol avatar May 12 '22 05:05 lufty-demansol

@mickmister , I have answered all questions. please take a look.

lufty-demansol avatar May 12 '22 05:05 lufty-demansol

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar May 23 '22 01:05 mattermod