Support for Gitlab merge request reviewers

[apollo13]

trafficstars

Gitlab 13.5 (behind a feature flag) introduced merge requests reviewers: https://about.gitlab.com/blog/2020/10/13/merge-request-reviewers/

It would be great if this plugin also listed those as needed review.

[apollo13]

This is now enabled for everyone and getting more features every release. I think it would make sense to move "merge requests needing review" over to "reviewers" instead of "assignee" as it is now. What do you think?

[mickmister]

Thanks for this @apollo13

This makes sense. I think we should mimic the functionality of the GitHub plugin.

Proposal

• "Merge requests needing review" should pull from merge requests that have your review requested
• "Your assignments" should pull from issues and merge requests where you are assigned

Currently the GitLab plugin has this behavior:

• "Merge requests needing review" category pulls from merge requests you are assigned to (as you pointed out):

Relevant code that is using assignee instead of review request relationship: https://github.com/mattermost/mattermost-plugin-gitlab/blob/3b9209074b2119903a74c6eed910516e6d40a5ce/server/gitlab/api.go#L237

• "Your assignments" pulls from issues you are assigned to, but not merge requests

https://github.com/mattermost/mattermost-plugin-gitlab/blob/3b9209074b2119903a74c6eed910516e6d40a5ce/server/gitlab/api.go#L294

Currently the GitHub plugin has this behavior:

• "Pull requests needing review" category pulls from pull requests that have your review requested
• "Your assignments" category pulls from your assignments on issues and pull requests.

[wiersgallak]

Closing due to inactivity. The issue can be reopened with more interest from our community.