mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

[MM-1007]: Web app test cases setup and added web app test cases for some UI components

Open Kshitij-Katiyar opened this issue 11 months ago • 3 comments

Summary

Webapp testcase setup and added web app test cases for the following UI components:

  • Github assignee selector
  • Github label selector
  • Github milestone selector
  • Github repo selector

Kshitij-Katiyar avatar Dec 17 '24 06:12 Kshitij-Katiyar

@rahimrahman I wonder if you have thoughts on the general setup of the test cases, given that you worked a lot of webapp test recently.

hanzei avatar Jan 06 '25 09:01 hanzei

@hanzei thanks for flagging me.

@Kshitij-Katiyar few things:

  • let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
  • let's eliminate the use of toMatchSnapshot() for more meaningful test.

rahimrahman avatar Jan 06 '25 19:01 rahimrahman

@hanzei thanks for flagging me.

@Kshitij-Katiyar few things:

  • let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
  • let's eliminate the use of toMatchSnapshot() for more meaningful test.

@rahimrahman Sure will update the test cases with the changes

Kshitij-Katiyar avatar Jan 10 '25 04:01 Kshitij-Katiyar

@hanzei thanks for flagging me.

@Kshitij-Katiyar few things:

  • let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
  • let's eliminate the use of toMatchSnapshot() for more meaningful test.

Due to these changes, i don't think this PR is much useful, It would be better to build this from scratch. Still keeping this PR open for context

abbas-dependable-naqvi avatar Oct 31 '25 12:10 abbas-dependable-naqvi

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Nov 12 '25 01:11 mattermost-build