mattermost-plugin-github
mattermost-plugin-github copied to clipboard
[MM-1007]: Web app test cases setup and added web app test cases for some UI components
Summary
Webapp testcase setup and added web app test cases for the following UI components:
- Github assignee selector
- Github label selector
- Github milestone selector
- Github repo selector
@rahimrahman I wonder if you have thoughts on the general setup of the test cases, given that you worked a lot of webapp test recently.
@hanzei thanks for flagging me.
@Kshitij-Katiyar few things:
- let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
- let's eliminate the use of toMatchSnapshot() for more meaningful test.
@hanzei thanks for flagging me.
@Kshitij-Katiyar few things:
- let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
- let's eliminate the use of toMatchSnapshot() for more meaningful test.
@rahimrahman Sure will update the test cases with the changes
@hanzei thanks for flagging me.
@Kshitij-Katiyar few things:
- let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
- let's eliminate the use of toMatchSnapshot() for more meaningful test.
Due to these changes, i don't think this PR is much useful, It would be better to build this from scratch. Still keeping this PR open for context
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!