mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

[MM-945]: Converting user_attribute component and client files to TS

Open Kshitij-Katiyar opened this issue 1 year ago • 2 comments

Summary

Converting user_attribute component and client files to TS and other changes"

Actual PR

https://github.com/mattermost/mattermost-plugin-github/pull/785

Kshitij-Katiyar avatar Nov 19 '24 10:11 Kshitij-Katiyar

@Kshitij-Katiyar @raghavaggarwal2308 it's tough to know if something was missed in a PR like this when no unit tests seem to exist that cover the changes. I'm thinking we should hold off on TS conversions until we have unit test coverage. Thoughts?

wiggin77 avatar Nov 30 '24 06:11 wiggin77

@wiggin77 We are just adding types to the existing files and not adding any functionality, so I am not sure how unit tests will be helpful here. If you are concerned that something is changed by mistake, we can have a QA do a high level sanity for these PRs. Please let me know your opinion.

raghavaggarwal2308 avatar Nov 30 '24 08:11 raghavaggarwal2308

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)

mm-prodsec-bot avatar Jul 03 '25 12:07 mm-prodsec-bot

@wiggin77 FIxed the CI

raghavaggarwal2308 avatar Aug 25 '25 06:08 raghavaggarwal2308

/update-branch

wiggin77 avatar Aug 27 '25 02:08 wiggin77

Error trying to update the PR. Please do it manually.

mattermost-build avatar Aug 27 '25 02:08 mattermost-build

@raghavaggarwal2308 is this up to date with master?

wiggin77 avatar Aug 27 '25 02:08 wiggin77

@wiggin77 Yes, its up to date

raghavaggarwal2308 avatar Aug 28 '25 07:08 raghavaggarwal2308