mattermost-plugin-github
mattermost-plugin-github copied to clipboard
[MM-945]: Converting user_attribute component and client files to TS
Summary
Converting user_attribute component and client files to TS and other changes"
Actual PR
https://github.com/mattermost/mattermost-plugin-github/pull/785
@Kshitij-Katiyar @raghavaggarwal2308 it's tough to know if something was missed in a PR like this when no unit tests seem to exist that cover the changes. I'm thinking we should hold off on TS conversions until we have unit test coverage. Thoughts?
@wiggin77 We are just adding types to the existing files and not adding any functionality, so I am not sure how unit tests will be helpful here. If you are concerned that something is changed by mistake, we can have a QA do a high level sanity for these PRs. Please let me know your opinion.
:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)
:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)
@wiggin77 FIxed the CI
/update-branch
Error trying to update the PR. Please do it manually.
@raghavaggarwal2308 is this up to date with master?
@wiggin77 Yes, its up to date