Fix missing PR notifications when using both pulls_created and pulls_merged features filter
Summary
There is currently a bug described in the linked issue below. If both pulls_created and pulls_merged features are set for a subscription, any type of PR events are ignored.
I have fixed the if statement, and now it is possible to use both values and receive notifications for the respective event types.
Ticket Link
Fixes https://github.com/mattermost/mattermost-plugin-github/issues/826
Hello @verdel,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Thanks @verdel
LGTM, Thanks for the contribution @verdel
Thank you for taking the time to review my PR
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/update-branch
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
As I understand, all the required checks for merging the PR have been successfully completed. Could I ask someone to perform the merge?
@verdel This PR is pending for QA review. We will try to get that done ASAP.
Yes, I apologize, I didn't notice the label on the PR. Thank you.
Merging this PR now, thanks for the contribution! @verdel