mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

Fix missing PR notifications when using both pulls_created and pulls_merged features filter

Open verdel opened this issue 1 year ago • 4 comments

Summary

There is currently a bug described in the linked issue below. If both pulls_created and pulls_merged features are set for a subscription, any type of PR events are ignored.

I have fixed the if statement, and now it is possible to use both values and receive notifications for the respective event types.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-github/issues/826

verdel avatar Sep 25 '24 21:09 verdel

Hello @verdel,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermost-build avatar Sep 25 '24 21:09 mattermost-build

Thanks @verdel

wiggin77 avatar Sep 25 '24 21:09 wiggin77

LGTM, Thanks for the contribution @verdel

Thank you for taking the time to review my PR

verdel avatar Oct 03 '24 14:10 verdel

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Oct 14 '24 01:10 mattermost-build

/update-branch

wiggin77 avatar Oct 22 '24 20:10 wiggin77

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermost-build avatar Nov 02 '24 01:11 mattermost-build

As I understand, all the required checks for merging the PR have been successfully completed. Could I ask someone to perform the merge?

verdel avatar Nov 16 '24 05:11 verdel

@verdel This PR is pending for QA review. We will try to get that done ASAP.

raghavaggarwal2308 avatar Nov 17 '24 16:11 raghavaggarwal2308

Yes, I apologize, I didn't notice the label on the PR. Thank you.

verdel avatar Nov 18 '24 06:11 verdel

Merging this PR now, thanks for the contribution! @verdel

raghavaggarwal2308 avatar Nov 21 '24 06:11 raghavaggarwal2308